From 3cfa604ed819d427a8b75257a9298abdd22241ca Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 8 Sep 2026 02:12:23 +0000 Subject: [PATCH] test: migrate `stats/base/dists/beta/stdev` to ULP-based assertions Replaces relative-tolerance comparisons in `test/test.js` and `test/test.native.js` with `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum of `2`; a bound of `1` fails for one fixture case. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_017Yzm1pYd69FheDzXXPPnR4 --- .../stats/base/dists/beta/stdev/test/test.js | 13 ++----------- .../stats/base/dists/beta/stdev/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/beta/stdev/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/beta/stdev/test/test.js index 677a9a96a7c1..30d2848fffd2 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/beta/stdev/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/beta/stdev/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var stdev = require( './../lib' ); @@ -96,10 +95,8 @@ tape( 'if provided `beta <= 0`, the function returns `NaN`', function test( t ) tape( 'the function returns the standard deviation of a beta distribution', function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var y; @@ -108,13 +105,7 @@ tape( 'the function returns the standard deviation of a beta distribution', func beta = data.beta; for ( i = 0; i < expected.length; i++ ) { y = stdev( alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.5 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/beta/stdev/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/beta/stdev/test/test.native.js index 25a3b4f55957..718de15474b7 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/beta/stdev/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/beta/stdev/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -105,10 +104,8 @@ tape( 'if provided `beta <= 0`, the function returns `NaN`', opts, function test tape( 'the function returns the standard deviation of a beta distribution', opts, function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var y; @@ -117,13 +114,7 @@ tape( 'the function returns the standard deviation of a beta distribution', opts beta = data.beta; for ( i = 0; i < expected.length; i++ ) { y = stdev( alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.5 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); });