From 790a4dc046cec7e43b469beef2cd9cfa08dd5101 Mon Sep 17 00:00:00 2001 From: Richard Osborne Date: Tue, 25 Aug 2026 09:56:50 -0500 Subject: [PATCH 1/3] bump electron to 43 --- .github/workflows/build.yml | 6 +++--- crash-handler-module/CMakeLists.txt | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6f1c1d2..1eccf05 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -19,7 +19,7 @@ env: BUILD_DIRECTORY: "build" DISTRIBUTE_DIRECTORY: "distribute" RELEASE_BUCKET: "slobs-crash-handler" - ELECTRON_VERSION: "v29.4.3" + ELECTRON_VERSION: "v43.2.0" BIN_DEPENDENCIES: "dependencies2019.0" AWS_SDK_VERSION: "1.11.704" AWS_SDK_PATH: "aws-sdk/awsi" @@ -40,7 +40,7 @@ jobs: - name: Install Node.js uses: actions/setup-node@v3 with: - node-version: '16.x' + node-version: '22.12.0' - name: Install dependencies run: yarn install --immutable --immutable-cache --check-cache @@ -195,7 +195,7 @@ jobs: - name: Install Node.js uses: actions/setup-node@v3 with: - node-version: '16.x' + node-version: '22.12.0' - name: Install dependencies run: yarn install --immutable --immutable-cache --check-cache - name: Prepare translations diff --git a/crash-handler-module/CMakeLists.txt b/crash-handler-module/CMakeLists.txt index 5aad9e5..7234980 100644 --- a/crash-handler-module/CMakeLists.txt +++ b/crash-handler-module/CMakeLists.txt @@ -3,7 +3,7 @@ project(crash-handler) SET(NODEJS_URL "https://artifacts.electronjs.org/headers/dist" CACHE STRING "Node.JS URL") SET(NODEJS_NAME "iojs" CACHE STRING "Node.JS Name") -SET(NODEJS_VERSION "v29.4.3" CACHE STRING "Node.JS Version") +SET(NODEJS_VERSION "v43.2.0" CACHE STRING "Node.JS Version") include(NodeJS) include(CPack) From 4c62dcc0ca5bc5244fe7cc3964ba1e6bb91a0b09 Mon Sep 17 00:00:00 2001 From: Richard Osborne Date: Tue, 25 Aug 2026 10:15:43 -0500 Subject: [PATCH 2/3] use node 24 / electron 43 --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1eccf05..fae8143 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -38,9 +38,9 @@ jobs: run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT shell: bash - name: Install Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '22.12.0' + node-version: '24.x' - name: Install dependencies run: yarn install --immutable --immutable-cache --check-cache @@ -193,9 +193,9 @@ jobs: run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT shell: bash - name: Install Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '22.12.0' + node-version: '24.x' - name: Install dependencies run: yarn install --immutable --immutable-cache --check-cache - name: Prepare translations From 9660c905af06c58e53765d4b68fda3fa57efc2d4 Mon Sep 17 00:00:00 2001 From: Richard Osborne Date: Tue, 25 Aug 2026 10:26:20 -0500 Subject: [PATCH 3/3] pin windows-2022 to find Visual Studio on CI --- .github/workflows/build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fae8143..4be7644 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -30,7 +30,7 @@ permissions: jobs: build: name: 'Build a package' - runs-on: windows-latest + runs-on: windows-2022 steps: - uses: actions/checkout@v3 - name: Get the version @@ -100,7 +100,7 @@ jobs: upload_debug_symbols: needs: build name: 'Upload debug symbols' - runs-on: windows-latest + runs-on: windows-2022 if: startsWith(github.ref, 'refs/tags/') steps: - name: Get the version of aws cli @@ -142,7 +142,7 @@ jobs: upload_release_package: needs: build name: 'Upload release package win' - runs-on: windows-latest + runs-on: windows-2022 if: startsWith(github.ref, 'refs/tags/') env: OS_TAG: "win64"