From ba7aa200314fadbee2ead5994639700375eda9b3 Mon Sep 17 00:00:00 2001 From: Cristian Greco Date: Thu, 8 Oct 2026 20:05:49 +0100 Subject: [PATCH] Declare missing module dependencies k3s imports tar-stream and selenium imports tar-fs and tmp at runtime without declaring them, so they only resolve through npm hoisting and crash on import under strict installs (pnpm hoist=false, Yarn PnP). Declare them, plus azurite's test-only @azure/core-auth, and enable Biome's noUndeclaredDependencies rule to keep it that way. --- biome.json | 17 ++++++++++++++++- package-lock.json | 11 +++++++++-- packages/modules/azurite/package.json | 1 + packages/modules/k3s/package.json | 4 +++- packages/modules/selenium/package.json | 6 +++++- 5 files changed, 34 insertions(+), 5 deletions(-) diff --git a/biome.json b/biome.json index f54aac69e..d4cafe1fe 100644 --- a/biome.json +++ b/biome.json @@ -22,9 +22,24 @@ "linter": { "enabled": true, "rules": { - "preset": "recommended" + "preset": "recommended", + "correctness": { + "noUndeclaredDependencies": "error" + } } }, + "overrides": [ + { + "includes": ["**/*.test.ts"], + "linter": { + "rules": { + "correctness": { + "noUndeclaredDependencies": "off" + } + } + } + } + ], "assist": { "enabled": true, "actions": { diff --git a/package-lock.json b/package-lock.json index c39d05e0d..5972ff8e6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -15262,6 +15262,7 @@ "testcontainers": "^12.2.0" }, "devDependencies": { + "@azure/core-auth": "^1.10.1", "@azure/data-tables": "^13.3.2", "@azure/storage-blob": "12.34.0", "@azure/storage-queue": "12.32.0" @@ -15417,10 +15418,12 @@ "version": "12.2.0", "license": "MIT", "dependencies": { + "tar-stream": "^3.1.7", "testcontainers": "^12.2.0" }, "devDependencies": { - "@kubernetes/client-node": "^2.0.0" + "@kubernetes/client-node": "^2.0.0", + "@types/tar-stream": "^3.1.3" } }, "packages/modules/kafka": { @@ -15679,10 +15682,14 @@ "version": "12.2.0", "license": "MIT", "dependencies": { - "testcontainers": "^12.2.0" + "tar-fs": "^3.1.3", + "testcontainers": "^12.2.0", + "tmp": "^0.2.7" }, "devDependencies": { "@types/selenium-webdriver": "^4.35.7", + "@types/tar-fs": "^2.0.4", + "@types/tmp": "^0.2.6", "selenium-webdriver": "^4.49.0" } }, diff --git a/packages/modules/azurite/package.json b/packages/modules/azurite/package.json index aec90db18..15070c6fa 100644 --- a/packages/modules/azurite/package.json +++ b/packages/modules/azurite/package.json @@ -32,6 +32,7 @@ "testcontainers": "^12.2.0" }, "devDependencies": { + "@azure/core-auth": "^1.10.1", "@azure/data-tables": "^13.3.2", "@azure/storage-blob": "12.34.0", "@azure/storage-queue": "12.32.0" diff --git a/packages/modules/k3s/package.json b/packages/modules/k3s/package.json index e7f408da9..3692a7dfc 100644 --- a/packages/modules/k3s/package.json +++ b/packages/modules/k3s/package.json @@ -29,9 +29,11 @@ "build": "tsc --project tsconfig.build.json" }, "dependencies": { + "tar-stream": "^3.1.7", "testcontainers": "^12.2.0" }, "devDependencies": { - "@kubernetes/client-node": "^2.0.0" + "@kubernetes/client-node": "^2.0.0", + "@types/tar-stream": "^3.1.3" } } diff --git a/packages/modules/selenium/package.json b/packages/modules/selenium/package.json index ed901a410..95f8532e7 100644 --- a/packages/modules/selenium/package.json +++ b/packages/modules/selenium/package.json @@ -30,9 +30,13 @@ }, "devDependencies": { "@types/selenium-webdriver": "^4.35.7", + "@types/tar-fs": "^2.0.4", + "@types/tmp": "^0.2.6", "selenium-webdriver": "^4.49.0" }, "dependencies": { - "testcontainers": "^12.2.0" + "tar-fs": "^3.1.3", + "testcontainers": "^12.2.0", + "tmp": "^0.2.7" } }