fix(webapp): keep finished runs' Redis snapshot state for 4 days instead of 14

Finished runs' execution snapshot state in the Redis snapshot store now
expires after 4 days instead of 14, keeping the store's memory bounded
to a few days of completions. Runs that are still active are unaffected,
and runs that finished before this change keep their existing expiry.

Mono-RevId: 6609ff96d5f3872e964e73072f0465e5fba4f1db

Author: d-cs

apps/webapp/app/v3/utils/snapshotStoreConnection.server.ts

@@ -4,7 +4,7 @@ import { RedisSnapshotStore, type SnapshotStoreMetrics } from "@internal/run-sto
 const COMMAND_TIMEOUT_MS = 500;
 const CONNECT_TIMEOUT_MS = 500;
 const POLICY_CHECK_INTERVAL_MS = 30_000;
-const COMPLETED_TTL_MS = 14 * 24 * 60 * 60 * 1_000;
+const COMPLETED_TTL_MS = 4 * 24 * 60 * 60 * 1_000;
 
 /** Infrastructure only. Rollout modes belong to the existing polled flags, not this URL. */
 export function snapshotClusterOptions(endpoint: string) {

internal-packages/run-store/src/redisSnapshotStore.residencyMarker.test.ts

@@ -1,5 +1,5 @@
 // Item 8d: a terminal MIRRORED run's residency marker expires WITH its state (its Postgres copy is
-// authoritative after 14 days, so no permanent per-run marker accumulates), while a REDIS-PRIMARY marker
+// authoritative once the completed TTL passes, so no permanent per-run marker accumulates), while a REDIS-PRIMARY marker
 // is kept forever so an expired redis-primary run resolves to expired/fail-closed rather than empty
 // Postgres. Proven against REAL Redis (testcontainers, no mocks).
 import { describe, expect } from "vitest";

internal-packages/run-store/src/redisSnapshotStore.ts

@@ -1483,7 +1483,7 @@ export class RedisSnapshotStore {
           for i = 1, high do
             redis.call('PEXPIRE', wpKey(i), ttlMs)
           end
-          -- A MIRRORED run's residency marker expires WITH its state: after 14 days the terminal keys are
+          -- A MIRRORED run's residency marker expires WITH its state: once the completed TTL passes the terminal keys are
           -- gone and its complete Postgres copy is authoritative, so a read cleanly misses to Postgres and
           -- no permanent per-run marker accumulates. A REDIS-PRIMARY marker is kept forever (no PEXPIRE):
           -- it is the only record the run was ever redis-primary, so an expired redis-primary run resolves

internal-packages/run-store/src/snapshotKeys.ts

@@ -41,7 +41,7 @@ export function snapshotKeys(runId: string): SnapshotKeys {
 
 /**
  * The Redis-primary residency marker key. Shares the run's partition tag but is a SEPARATE physical
- * key: it has no TTL ever, so it outlives the run-state keys once they take the terminal 14-day TTL.
+ * key: it has no TTL ever, so it outlives the run-state keys once they take the terminal completed TTL.
  */
 export function residencyKey(runId: string): string {
   return `${SNAPSHOT_NAMESPACE}:res:{${partitionTag(runToPartition(runId))}}:${runId}`;

scripts/compare-snapshot-stores.mts

@@ -255,8 +255,8 @@ function emptySkipped(): SkippedRuns {
   return { postgres: 0, redisPrimary: 0, noSnapshots: 0, unknown: 0, expired: 0 };
 }
 
-/** Finished runs keep their MemoryDB keys for this long, then the whole keyspace expires. */
-export const FINISHED_RUN_RETENTION_MS = 14 * 24 * 60 * 60 * 1000;
+/** Finished runs keep their MemoryDB keys for this long, then the whole keyspace expires. Matches the webapp's completed TTL. */
+export const FINISHED_RUN_RETENTION_MS = 4 * 24 * 60 * 60 * 1000;
 
 function isExpired(
   rows: PostgresSnapshotRow[],