refactor(run-engine,webapp): drop per-key override admit reads and limit column

Removes the override-aware admit and gauge reads from the CK Lua scripts and
the per-key limit column, following the removal of runtime per-key overrides
from this stack.

Author: matt-aitken

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues_.$queueParam/route.tsx

@@ -407,13 +407,7 @@ export default function Page() {
         {view === "keys" && hasKeys ? (
           <>
             <MetricsLayout.Content>
-              <KeyStatsTable
-                ids={ids}
-                timeRange={timeRange}
-                queueName={fullName}
-                defaultKeyLimit={queue.concurrencyLimit ?? environmentConcurrencyLimit}
-                envLimit={environmentConcurrencyLimit}
-              />
+              <KeyStatsTable ids={ids} timeRange={timeRange} queueName={fullName} />
             </MetricsLayout.Content>
             {selectedKey ? (
               <MetricsLayout.Content inset>
@@ -966,15 +960,10 @@ function KeyStatsTable({
   ids,
   timeRange,
   queueName,
-  defaultKeyLimit,
-  envLimit,
 }: {
   ids: Ids;
   timeRange: TimeRangeParams;
   queueName: string;
-  /** The limit a key inherits when it has no override (the queue's limit, else the env limit). */
-  defaultKeyLimit: number;
-  envLimit: number;
 }) {
   const { value, replace, del } = useSearchParams();
   const selectedKey = value("key");
@@ -1017,12 +1006,6 @@ function KeyStatsTable({
             <TableHeaderCell>Key</TableHeaderCell>
             <TableHeaderCell alignment="right">Queued now</TableHeaderCell>
             <TableHeaderCell alignment="right">Running now</TableHeaderCell>
-            <TableHeaderCell
-              alignment="right"
-              tooltip="The key's concurrency limit. Keys inherit the queue's limit unless a per-key override is set via the API."
-            >
-              Limit
-            </TableHeaderCell>
             <TableHeaderCell alignment="right">Oldest wait</TableHeaderCell>
             <TableHeaderCell alignment="right">Started</TableHeaderCell>
             <TableHeaderCell alignment="right">Peak backlog</TableHeaderCell>
@@ -1031,11 +1014,11 @@ function KeyStatsTable({
         </TableHeader>
         <TableBody>
           {showLoading ? (
-            <TableBlankRow colSpan={8} className="text-text-dimmed">
+            <TableBlankRow colSpan={7} className="text-text-dimmed">
               Loading…
             </TableBlankRow>
           ) : rows.length === 0 ? (
-            <TableBlankRow colSpan={8} className="text-text-dimmed">
+            <TableBlankRow colSpan={7} className="text-text-dimmed">
               {search ? `No keys match “${search}”` : "No concurrency keys"}
             </TableBlankRow>
           ) : (
@@ -1049,12 +1032,6 @@ function KeyStatsTable({
                 <TableCell>{row.key}</TableCell>
                 <TableCell alignment="right">{row.queued.toLocaleString()}</TableCell>
                 <TableCell alignment="right">{row.running.toLocaleString()}</TableCell>
-                <TableCell
-                  alignment="right"
-                  className={row.limitOverride !== null ? undefined : "text-text-dimmed"}
-                >
-                  {Math.min(row.limitOverride ?? defaultKeyLimit, envLimit).toLocaleString()}
-                </TableCell>
                 <TableCell alignment="right">
                   {row.oldestWaitMs === null ? "–" : formatWaitMs(row.oldestWaitMs)}
                 </TableCell>

apps/webapp/app/v3/querySchemas.ts

@@ -1426,7 +1426,7 @@ const queueMetricsByKeySchema: TableSchema = {
       name: "max_limit",
       ...column("UInt32", {
         description:
-          "The effective concurrency limit for this key (the queue limit, or its per-key override). Aggregate with max().",
+          "The queue concurrency limit that applied to this key in the bucket. Aggregate with max().",
         fillMode: "carry",
       }),
     },

internal-packages/clickhouse/schema/042_add_queue_metrics_combined_concurrency.sql

@@ -4,7 +4,7 @@
 -- concurrency-key variants of a queue (the groupConcurrency set), combined_limit the
 -- RAW stored total cap (0 = none, readers clamp against max_env_limit). Emitted on
 -- base-queue gauge rows only. Per-key gauge rows now carry the EFFECTIVE per-key
--- limit in queue_limit (override-aware), surfaced in the ck tier as max_limit.
+-- limit in queue_limit, surfaced in the ck tier as max_limit.
 
 ALTER TABLE trigger_dev.queue_metrics_raw_v1
   ADD COLUMN IF NOT EXISTS combined_running UInt32 DEFAULT 0,