From 5509d9f9512cc6c3cd7c69ef8c64dc8c07d9ebd5 Mon Sep 17 00:00:00 2001
From: Ameen Rashad <7609895+vazra@users.noreply.github.com>
Date: Sun, 11 Oct 2026 02:29:25 -0700
Subject: [PATCH 1/6] fix(ui): give each endpoint its own quick test domain in
 multi-endpoint templates

---
 docs/first-deploy/ui.md                       |  2 +-
 ui/src/components/TemplatePicker.svelte       | 36 +++++++----
 .../__tests__/TemplatePicker.test.js          | 62 ++++++++++++++++++-
 ui/src/lib/__tests__/appTemplates.test.js     | 45 ++++++++++++++
 ui/src/lib/appTemplates.js                    | 25 ++++++++
 5 files changed, 156 insertions(+), 14 deletions(-)

diff --git a/docs/first-deploy/ui.md b/docs/first-deploy/ui.md
index 7d2baa64..78c1470d 100644
--- a/docs/first-deploy/ui.md
+++ b/docs/first-deploy/ui.md
@@ -22,7 +22,7 @@ The fastest way to deploy if you already have the dashboard open.
 
    Templates ask you to pick an **Access mode** before continuing:
 
-   - **Quick test** (default): SimpleDeploy auto-generates a `<slug>.<server-ip>.sslip.io` domain and issues a self-signed cert via Caddy's internal CA. No DNS setup needed. Browsers will warn about the certificate until you install the root cert from the **Trust** page on your SimpleDeploy server (`/trust` on the server URL). Best for trying a template in minutes on a homelab, LAN, or VPS without public DNS.
+   - **Quick test** (default): SimpleDeploy auto-generates a `<slug>.<server-ip>.sslip.io` domain (templates with more than one web address get one per address, e.g. `minio.<server-ip>.sslip.io` and `minio-console.<server-ip>.sslip.io`) and issues a self-signed cert via Caddy's internal CA. No DNS setup needed. Browsers will warn about the certificate until you install the root cert from the **Trust** page on your SimpleDeploy server (`/trust` on the server URL). Best for trying a template in minutes on a homelab, LAN, or VPS without public DNS.
    - **Custom domain**: You supply a real public domain and point its DNS at the server. TLS is provisioned automatically via Let's Encrypt. Best for production.
    - **Port only**: Skips the Caddy proxy entirely. Docker picks a random host port; you reach the app at `http://<server>:<port>`. Disabled for multi-endpoint templates. Best for SSH-tunnel or LAN-only testing.
 
diff --git a/ui/src/components/TemplatePicker.svelte b/ui/src/components/TemplatePicker.svelte
index e7f260d5..a8ffc5c5 100644
--- a/ui/src/components/TemplatePicker.svelte
+++ b/ui/src/components/TemplatePicker.svelte
@@ -1,5 +1,5 @@
 <script>
-  import { generateSecret, validateVars, countEndpoints, computeQuickTestDomain, isValidIPv4, DEFAULT_ACCESS_MODE } from '../lib/appTemplates.js'
+  import { generateSecret, validateVars, countEndpoints, computeQuickTestDomain, computeQuickTestDomains, isValidIPv4, DEFAULT_ACCESS_MODE } from '../lib/appTemplates.js'
   import { api } from '../lib/api.js'
   import CommunityRecipeBrowser from './CommunityRecipeBrowser.svelte'
 
@@ -40,6 +40,14 @@
   let quickDomain = $derived(
     selected ? computeQuickTestDomain(selected.nameSuggestion, quickHost || 'localhost') : ''
   )
+  // One auto domain per domain variable, so multi-endpoint templates get distinct hostnames.
+  let quickDomainRows = $derived.by(() => {
+    if (!selected) return []
+    const domains = computeQuickTestDomains(selected.variables, selected.nameSuggestion, quickHost || 'localhost')
+    return (selected.variables || [])
+      .filter((v) => domains[v.key])
+      .map((v) => ({ key: v.key, label: v.label || v.key, domain: domains[v.key] }))
+  })
   let hostValid = $derived(isValidIPv4(quickHost))
   let hostChanged = $derived(quickHost !== loadedHost)
 
@@ -206,8 +214,7 @@
     // Inject domain values based on access mode.
     const domainVars = (selected.variables || []).filter((v) => v.type === 'domain')
     if (accessMode === 'quick-test') {
-      const d = computeQuickTestDomain(selected.nameSuggestion, quickHost)
-      for (const v of domainVars) merged[v.key] = d
+      Object.assign(merged, computeQuickTestDomains(domainVars, selected.nameSuggestion, quickHost))
     } else if (accessMode === 'port-only') {
       for (const v of domainVars) merged[v.key] = 'localhost' // placeholder; labels stripped anyway
     }
@@ -401,15 +408,20 @@
 
       {#if accessMode === 'quick-test'}
         <div class="bg-surface-3/40 border border-border/30 rounded-lg px-3 py-3 flex flex-col gap-2">
-          <div>
-            <label class="block text-xs text-text-muted mb-1">Domain (auto)</label>
-            <input
-              type="text"
-              readonly
-              value={quickDomain}
-              class="w-full px-3 py-2 bg-input-bg/50 border border-border/30 rounded-lg text-sm text-text-primary font-mono"
-            />
-          </div>
+          {#each quickDomainRows as row (row.key)}
+            <div>
+              <label class="block text-xs text-text-muted mb-1" for="tpl-quick-{row.key}">
+                {quickDomainRows.length > 1 ? `${row.label} (auto)` : 'Domain (auto)'}
+              </label>
+              <input
+                id="tpl-quick-{row.key}"
+                type="text"
+                readonly
+                value={row.domain}
+                class="w-full px-3 py-2 bg-input-bg/50 border border-border/30 rounded-lg text-sm text-text-primary font-mono"
+              />
+            </div>
+          {/each}
           <div>
             <label class="block text-xs text-text-muted mb-1">Server IP (IPv4 required by sslip.io)</label>
             <div class="flex items-center gap-1.5">
diff --git a/ui/src/components/__tests__/TemplatePicker.test.js b/ui/src/components/__tests__/TemplatePicker.test.js
index 68f8bf37..967cd834 100644
--- a/ui/src/components/__tests__/TemplatePicker.test.js
+++ b/ui/src/components/__tests__/TemplatePicker.test.js
@@ -1,5 +1,5 @@
 import { describe, it, expect, vi } from 'vitest';
-import { render, fireEvent } from '@testing-library/svelte';
+import { render, fireEvent, waitFor } from '@testing-library/svelte';
 
 vi.mock('../../lib/api.js', async () => {
   const { makeApiMock } = await import('../../test-mocks/api.js');
@@ -7,6 +7,13 @@ vi.mock('../../lib/api.js', async () => {
 });
 
 import TemplatePicker from '../TemplatePicker.svelte';
+import {
+  appTemplates,
+  categories as appCategories,
+  applyVars,
+  applyAccessMode,
+} from '../../lib/appTemplates.js';
+import { parseEndpointLabels } from '../../lib/endpointLabels.js';
 
 const templates = [
   {
@@ -77,3 +84,56 @@ describe('TemplatePicker (grid)', () => {
     expect(getByRole('button', { name: /browse community recipes/i })).toBeInTheDocument();
   });
 });
+
+describe('TemplatePicker (quick test defaults)', () => {
+  // The server rejects endpoints sharing domain + path + grpc matcher, so
+  // Quick test must give every endpoint of a template its own hostname.
+  it.each(appTemplates.map((t) => [t.id, t]))('%s applies with distinct endpoints', async (_id, t) => {
+    const onapply = vi.fn();
+    const { container, getByRole, getByPlaceholderText } = render(TemplatePicker, {
+      templates: appTemplates,
+      categories: appCategories,
+      initialTemplateId: t.id,
+      onapply,
+    });
+    // Wait for the public host lookup to settle on the browser fallback IP.
+    await waitFor(() => expect(getByPlaceholderText(/203\.0\.113\.10/)).toHaveValue('127.0.0.1'));
+    // Fill required fields that have no default (e.g. admin email).
+    for (const v of t.variables || []) {
+      if (!v.required || v.type === 'domain' || v.default != null || v.generate) continue;
+      const input = container.querySelector(`#tpl-var-${v.key}`);
+      await fireEvent.input(input, { target: { value: v.type === 'email' ? 'admin@example.com' : 'admin' } });
+    }
+    await fireEvent.click(getByRole('button', { name: /apply/i }));
+    expect(onapply).toHaveBeenCalledTimes(1);
+    const { vars, accessMode } = onapply.mock.calls[0][0];
+    expect(accessMode).toBe('quick-test');
+    const resolved = applyAccessMode(applyVars(t.compose, vars), accessMode);
+    const eps = parseEndpointLabels(resolved.services);
+    expect(eps.length).toBeGreaterThan(0);
+    const keys = eps.map((e) => `${e.domain}|${e.protocol === 'grpc'}|${e.path || ''}`);
+    expect(new Set(keys).size).toBe(keys.length);
+    for (const e of eps) expect(e.domain).toMatch(/\.127\.0\.0\.1\.sslip\.io$/);
+  });
+
+  it('shows one auto domain per endpoint for multi-domain templates', async () => {
+    const { getByLabelText, getByPlaceholderText } = render(TemplatePicker, {
+      templates: appTemplates,
+      categories: appCategories,
+      initialTemplateId: 'minio',
+    });
+    await waitFor(() => expect(getByPlaceholderText(/203\.0\.113\.10/)).toHaveValue('127.0.0.1'));
+    expect(getByLabelText('API domain (auto)')).toHaveValue('minio.127.0.0.1.sslip.io');
+    expect(getByLabelText('Console domain (auto)')).toHaveValue('minio-console.127.0.0.1.sslip.io');
+  });
+
+  it('keeps a single "Domain (auto)" field for single-domain templates', async () => {
+    const { getByLabelText, getByPlaceholderText } = render(TemplatePicker, {
+      templates: appTemplates,
+      categories: appCategories,
+      initialTemplateId: 'uptime-kuma',
+    });
+    await waitFor(() => expect(getByPlaceholderText(/203\.0\.113\.10/)).toHaveValue('127.0.0.1'));
+    expect(getByLabelText('Domain (auto)')).toHaveValue('uptime.127.0.0.1.sslip.io');
+  });
+});
diff --git a/ui/src/lib/__tests__/appTemplates.test.js b/ui/src/lib/__tests__/appTemplates.test.js
index 41f1dd91..1289cd1a 100644
--- a/ui/src/lib/__tests__/appTemplates.test.js
+++ b/ui/src/lib/__tests__/appTemplates.test.js
@@ -10,6 +10,7 @@ import {
   applyAccessMode,
   countEndpoints,
   computeQuickTestDomain,
+  computeQuickTestDomains,
   isValidHost,
   isValidIPv4,
 } from '../appTemplates.js';
@@ -111,6 +112,50 @@ describe('computeQuickTestDomain', () => {
   });
 });
 
+describe('computeQuickTestDomains', () => {
+  const d = (key, extra = {}) => ({ key, type: 'domain', ...extra });
+
+  it('gives the main domain var the plain slug', () => {
+    expect(computeQuickTestDomains([d('domain'), { key: 'x', type: 'text' }], 'app', '1.2.3.4'))
+      .toEqual({ domain: 'app.1.2.3.4.sslip.io' });
+  });
+
+  it('prefixes other domain vars by key so hostnames are distinct', () => {
+    expect(computeQuickTestDomains([d('domain'), d('console_domain'), d('ui_domain')], 'minio', '1.2.3.4'))
+      .toEqual({
+        domain: 'minio.1.2.3.4.sslip.io',
+        console_domain: 'minio-console.1.2.3.4.sslip.io',
+        ui_domain: 'minio-ui.1.2.3.4.sslip.io',
+      });
+  });
+
+  it('uses the first domain var as main when none is keyed "domain"', () => {
+    expect(computeQuickTestDomains([d('web_domain'), d('api_domain')], 'app', '1.2.3.4'))
+      .toEqual({ web_domain: 'app.1.2.3.4.sslip.io', api_domain: 'app-api.1.2.3.4.sslip.io' });
+  });
+
+  it('dedupes labels that sanitize to the same name', () => {
+    const out = computeQuickTestDomains([d('domain'), d('a_domain'), d('A_domain'), d('_domain')], 'app', '1.2.3.4');
+    expect(out.a_domain).toBe('app-a.1.2.3.4.sslip.io');
+    expect(out.A_domain).toBe('app-a-2.1.2.3.4.sslip.io');
+    expect(out._domain).toBe('app-alt.1.2.3.4.sslip.io');
+    expect(new Set(Object.values(out)).size).toBe(4);
+  });
+
+  it('every domain var of every app template gets a unique valid hostname', () => {
+    for (const t of appTemplates) {
+      const out = computeQuickTestDomains(t.variables, t.nameSuggestion, '1.2.3.4');
+      const keys = (t.variables || []).filter((v) => v.type === 'domain').map((v) => v.key);
+      expect(Object.keys(out).sort()).toEqual([...keys].sort());
+      expect(new Set(Object.values(out)).size).toBe(keys.length);
+      const vars = Object.fromEntries(keys.map((k) => [k, out[k]]));
+      for (const k of keys) {
+        expect(validateVars(t.variables.filter((v) => v.key === k), vars)).toEqual({});
+      }
+    }
+  });
+});
+
 describe('isValidHost', () => {
   it('accepts IPv4', () => {
     expect(isValidHost('192.168.1.1')).toBe(true);
diff --git a/ui/src/lib/appTemplates.js b/ui/src/lib/appTemplates.js
index e10c3180..ff87c9aa 100644
--- a/ui/src/lib/appTemplates.js
+++ b/ui/src/lib/appTemplates.js
@@ -115,6 +115,31 @@ export function computeQuickTestDomain(slug, host) {
   return `${slug}.${host}.sslip.io`;
 }
 
+// Quick-test domains for every domain variable of a template, as {key: domain}.
+// The main var ("domain", else the first) gets <slug>.<host>.sslip.io; others
+// get <slug>-<name>, where name is the key minus "_domain" (e.g. console_domain
+// -> minio-console), so endpoints never share a hostname (the server rejects
+// duplicate domain+path endpoints).
+export function computeQuickTestDomains(variables, slug, host) {
+  const domainVars = (variables || []).filter((v) => v.type === 'domain');
+  const main = domainVars.find((v) => v.key === 'domain') || domainVars[0];
+  const out = {};
+  const used = new Set();
+  if (main) {
+    out[main.key] = computeQuickTestDomain(slug, host);
+    used.add(slug);
+  }
+  for (const v of domainVars) {
+    if (v === main) continue;
+    const name = v.key.toLowerCase().replace(/_?domain$/, '').replace(/[^a-z0-9]+/g, '-').replace(/^-+|-+$/g, '') || 'alt';
+    let label = `${slug}-${name}`;
+    for (let i = 2; used.has(label); i++) label = `${slug}-${name}-${i}`;
+    used.add(label);
+    out[v.key] = computeQuickTestDomain(label, host);
+  }
+  return out;
+}
+
 // Transform compose according to access mode.
 // opts = { host, slug } (only used by quick-test indirectly; port-only uses labels).
 export function applyAccessMode(compose, mode, _opts) {

From d4d086643088a6d0f3cd76ed0b4f40113e9f93f6 Mon Sep 17 00:00:00 2001
From: Ameen Rashad <7609895+vazra@users.noreply.github.com>
Date: Sun, 11 Oct 2026 02:32:43 -0700
Subject: [PATCH 2/6] fix(ui): declare named volumes when adding a service from
 a template

---
 docs/first-deploy/ui.md                       |   2 +-
 ui/src/components/VisualEditor.svelte         |  10 +-
 .../components/__tests__/VisualEditor.test.js |  29 +++++
 ui/src/lib/__tests__/serviceTemplates.test.js | 104 +++++++++++++++++-
 ui/src/lib/serviceTemplates.js                |  57 ++++++++++
 5 files changed, 193 insertions(+), 9 deletions(-)

diff --git a/docs/first-deploy/ui.md b/docs/first-deploy/ui.md
index 78c1470d..de664f97 100644
--- a/docs/first-deploy/ui.md
+++ b/docs/first-deploy/ui.md
@@ -16,7 +16,7 @@ The fastest way to deploy if you already have the dashboard open.
 3. The deploy wizard opens on a **Start** chooser with two primary options:
 
    - **Upload docker-compose file**: pick a `docker-compose.yml` from disk.
-   - **Build it yourself**: open the visual builder and add services, ports, env vars, and volumes step by step. You can switch to a raw YAML editor at any time.
+   - **Build it yourself**: open the visual builder and add services, ports, env vars, and volumes step by step. You can switch to a raw YAML editor at any time. Adding a service from a quick-start template (e.g. PostgreSQL) also creates the storage volume it needs; if that name is already used, a number is appended (e.g. `pgdata2`) so two services never share data.
 
    If you just want a quick start or an example to learn from, click **Browse templates** below the two options to pick a preconfigured app or service template.
 
diff --git a/ui/src/components/VisualEditor.svelte b/ui/src/components/VisualEditor.svelte
index f973cc10..b92758bb 100644
--- a/ui/src/components/VisualEditor.svelte
+++ b/ui/src/components/VisualEditor.svelte
@@ -3,7 +3,7 @@
   import { api } from '../lib/api.js'
   import AccordionSection from './AccordionSection.svelte'
   import RepeatableField from './RepeatableField.svelte'
-  import { serviceTemplates } from '../lib/serviceTemplates.js'
+  import { serviceTemplates, addServiceToCompose } from '../lib/serviceTemplates.js'
   import { getImageDefaults, getHealthcheckSuggestion } from '../lib/imageDefaults.js'
   import { parseEndpointLabels, writeEndpointLabels } from '../lib/endpointLabels.js'
   import { MASKED_ENV_PLACEHOLDER, envDisplayValue, hasMaskedEnv } from '../lib/env.js'
@@ -325,12 +325,8 @@
   // ---- Add service ----
   function addService(template = null) {
     const updated = deepClone(compose)
-    if (!updated.services) updated.services = {}
-    const baseName = template?.id === 'blank' || !template ? 'service' : template.id.replace(/-/g, '_')
-    let name = baseName
-    let n = 1
-    while (updated.services[name]) { n++; name = `${baseName}${n}` }
-    updated.services[name] = template?.config ? deepClone(template.config) : { image: '', restart: 'unless-stopped' }
+    // Also declares the template's named volumes at the top level.
+    const name = addServiceToCompose(updated, template)
     emitChange(updated)
     showTemplatesPicker = false
     editingServices = new Set([...editingServices, name])
diff --git a/ui/src/components/__tests__/VisualEditor.test.js b/ui/src/components/__tests__/VisualEditor.test.js
index a2979ad3..07344684 100644
--- a/ui/src/components/__tests__/VisualEditor.test.js
+++ b/ui/src/components/__tests__/VisualEditor.test.js
@@ -137,3 +137,32 @@ describe('VisualEditor (smoke)', () => {
     });
   });
 });
+
+describe('VisualEditor add service from template', () => {
+  // Regression: the service was copied but its named volume was never
+  // declared, so `docker compose up` failed with "undefined volume pgdata".
+  it('declares the named volumes the new service references', async () => {
+    const onchange = vi.fn();
+    const { getByText } = render(VisualEditor, { compose: { services: {} }, slug: '', onchange });
+    await fireEvent.click(getByText('Add Service'));
+    await fireEvent.click(getByText('PostgreSQL'));
+    expect(onchange).toHaveBeenCalledTimes(1);
+    const next = onchange.mock.calls[0][0];
+    expect(next.services.postgresql.volumes).toEqual(['pgdata:/var/lib/postgresql/data']);
+    expect(next.volumes).toEqual({ pgdata: {} });
+  });
+
+  it('gives a second copy its own volume and keeps existing volume config', async () => {
+    const onchange = vi.fn();
+    const compose = {
+      services: { postgresql: { image: 'postgres:16-alpine', volumes: ['pgdata:/var/lib/postgresql/data'] } },
+      volumes: { pgdata: { driver: 'local' } },
+    };
+    const { getByText } = render(VisualEditor, { compose, slug: '', onchange });
+    await fireEvent.click(getByText('Add Service'));
+    await fireEvent.click(getByText('PostgreSQL'));
+    const next = onchange.mock.calls[0][0];
+    expect(next.services.postgresql2.volumes).toEqual(['pgdata2:/var/lib/postgresql/data']);
+    expect(next.volumes).toEqual({ pgdata: { driver: 'local' }, pgdata2: {} });
+  });
+});
diff --git a/ui/src/lib/__tests__/serviceTemplates.test.js b/ui/src/lib/__tests__/serviceTemplates.test.js
index 479f4699..65036e2e 100644
--- a/ui/src/lib/__tests__/serviceTemplates.test.js
+++ b/ui/src/lib/__tests__/serviceTemplates.test.js
@@ -1,7 +1,109 @@
 import { describe, it, expect } from 'vitest';
-import { serviceTemplates } from '../serviceTemplates.js';
+import { serviceTemplates, namedVolumeSource, addServiceToCompose } from '../serviceTemplates.js';
 import { appTemplates } from '../appTemplates.js';
 
+// Named volumes referenced by any service, as a sorted list.
+function referencedVolumes(compose) {
+  const names = new Set();
+  for (const svc of Object.values(compose.services || {})) {
+    for (const v of svc.volumes || []) {
+      const n = namedVolumeSource(v);
+      if (n) names.add(n);
+    }
+  }
+  return [...names].sort();
+}
+
+describe('namedVolumeSource', () => {
+  it('returns the volume name for short syntax named volumes', () => {
+    expect(namedVolumeSource('pgdata:/var/lib/postgresql/data')).toBe('pgdata');
+    expect(namedVolumeSource('my_vol.1:/data:ro')).toBe('my_vol.1');
+  });
+
+  it('returns null for bind mounts and anonymous volumes', () => {
+    expect(namedVolumeSource('/etc/localtime:/etc/localtime:ro')).toBeNull();
+    expect(namedVolumeSource('./data:/data')).toBeNull();
+    expect(namedVolumeSource('~/data:/data')).toBeNull();
+    expect(namedVolumeSource('${DATA_DIR}:/data')).toBeNull();
+    expect(namedVolumeSource('/data')).toBeNull();
+  });
+
+  it('handles long syntax', () => {
+    expect(namedVolumeSource({ type: 'volume', source: 'data', target: '/data' })).toBe('data');
+    expect(namedVolumeSource({ type: 'bind', source: '/srv', target: '/data' })).toBeNull();
+    expect(namedVolumeSource({ type: 'volume', target: '/data' })).toBeNull();
+  });
+});
+
+describe('addServiceToCompose', () => {
+  it.each(serviceTemplates.map((t) => [t.id, t]))(
+    '%s: declares every named volume its service references',
+    (_id, t) => {
+      const compose = { services: {} };
+      const name = addServiceToCompose(compose, t);
+      expect(name).toBe(t.id.replace(/-/g, '_'));
+      expect(compose.services[name].image).toBe(t.config.image);
+      expect(Object.keys(compose.volumes || {}).sort()).toEqual(referencedVolumes(compose));
+    },
+  );
+
+  it('each template added twice gets separate volumes for the second copy', () => {
+    for (const t of serviceTemplates) {
+      const compose = { services: {} };
+      addServiceToCompose(compose, t);
+      const second = addServiceToCompose(compose, t);
+      const first = referencedVolumes({ services: { a: compose.services[t.id.replace(/-/g, '_')] } });
+      const mine = referencedVolumes({ services: { a: compose.services[second] } });
+      expect(mine.filter((v) => first.includes(v)), t.id).toEqual([]);
+      expect(Object.keys(compose.volumes || {}).sort(), t.id).toEqual(referencedVolumes(compose));
+    }
+  });
+
+  it('suffixes clashing volumes like service names and keeps existing entries', () => {
+    const pg = serviceTemplates.find((t) => t.id === 'postgresql');
+    const compose = {
+      services: { other: { image: 'x', volumes: ['pgdata2:/x'] } },
+      volumes: { pgdata: { driver: 'local' } },
+    };
+    const name = addServiceToCompose(compose, pg);
+    expect(name).toBe('postgresql');
+    expect(compose.services.postgresql.volumes).toEqual(['pgdata3:/var/lib/postgresql/data']);
+    expect(compose.volumes).toEqual({ pgdata: { driver: 'local' }, pgdata3: {} });
+  });
+
+  it('does not declare bind mounts', () => {
+    const gitea = serviceTemplates.find((t) => t.id === 'gitea');
+    const compose = { services: {} };
+    addServiceToCompose(compose, gitea);
+    expect(compose.volumes).toEqual({ giteadata: {} });
+    expect(compose.services.gitea.volumes).toEqual(gitea.config.volumes);
+  });
+
+  it('rewrites long syntax sources when renaming', () => {
+    const tpl = { id: 'svc', config: { image: 'x:1', volumes: [{ type: 'volume', source: 'data', target: '/d' }] } };
+    const compose = { services: {}, volumes: { data: {} } };
+    addServiceToCompose(compose, tpl);
+    expect(compose.services.svc.volumes).toEqual([{ type: 'volume', source: 'data2', target: '/d' }]);
+    expect(compose.volumes).toEqual({ data: {}, data2: {} });
+  });
+
+  it('does not mutate the template config', () => {
+    const pg = serviceTemplates.find((t) => t.id === 'postgresql');
+    const before = JSON.stringify(pg.config);
+    const compose = { services: {}, volumes: { pgdata: {} } };
+    addServiceToCompose(compose, pg);
+    expect(JSON.stringify(pg.config)).toBe(before);
+  });
+
+  it('adds a blank service without template or for the blank id', () => {
+    const compose = {};
+    expect(addServiceToCompose(compose, null)).toBe('service');
+    expect(addServiceToCompose(compose, { id: 'blank' })).toBe('service2');
+    expect(compose.services.service).toEqual({ image: '', restart: 'unless-stopped' });
+    expect(compose.volumes).toBeUndefined();
+  });
+});
+
 describe('serviceTemplates integrity', () => {
   it('every template has required fields', () => {
     for (const t of serviceTemplates) {
diff --git a/ui/src/lib/serviceTemplates.js b/ui/src/lib/serviceTemplates.js
index 0b552cbf..069e895a 100644
--- a/ui/src/lib/serviceTemplates.js
+++ b/ui/src/lib/serviceTemplates.js
@@ -650,3 +650,60 @@ export const serviceTemplates = [
     },
   },
 ];
+
+// Named volume a service volume entry refers to, or null for bind mounts
+// (/x, ./x, ~/x), interpolated sources and anonymous volumes.
+export function namedVolumeSource(entry) {
+  let src = null;
+  if (typeof entry === 'string') {
+    const i = entry.indexOf(':');
+    if (i > 0) src = entry.slice(0, i);
+  } else if (entry && typeof entry === 'object' && entry.type === 'volume') {
+    src = entry.source;
+  }
+  return typeof src === 'string' && /^[A-Za-z0-9][A-Za-z0-9_.-]*$/.test(src) ? src : null;
+}
+
+// Adds a service to `compose` (mutated) from a service template, or a blank
+// service when template is null or "blank". Returns the new service name.
+// Names get a numeric suffix on collision (postgresql, postgresql2, ...).
+// Named volumes the service uses are declared at the top level; one already
+// declared or used gets the same suffixing (pgdata -> pgdata2) so the new
+// service never shares data with an existing one.
+export function addServiceToCompose(compose, template = null) {
+  if (!compose.services) compose.services = {};
+  const blank = !template || template.id === 'blank';
+  const baseName = blank ? 'service' : template.id.replace(/-/g, '_');
+  let name = baseName;
+  for (let n = 2; compose.services[name]; n++) name = `${baseName}${n}`;
+  const svc = !blank && template.config
+    ? JSON.parse(JSON.stringify(template.config))
+    : { image: '', restart: 'unless-stopped' };
+
+  const taken = new Set(Object.keys(compose.volumes || {}));
+  for (const other of Object.values(compose.services)) {
+    for (const v of other?.volumes || []) {
+      const n = namedVolumeSource(v);
+      if (n) taken.add(n);
+    }
+  }
+  const renamed = {};
+  if (Array.isArray(svc.volumes)) {
+    svc.volumes = svc.volumes.map((v) => {
+      const src = namedVolumeSource(v);
+      if (!src) return v;
+      if (!renamed[src]) {
+        let vol = src;
+        for (let n = 2; taken.has(vol); n++) vol = `${src}${n}`;
+        taken.add(vol);
+        renamed[src] = vol;
+        if (!compose.volumes) compose.volumes = {};
+        compose.volumes[vol] = {};
+      }
+      const vol = renamed[src];
+      return typeof v === 'string' ? vol + v.slice(src.length) : { ...v, source: vol };
+    });
+  }
+  compose.services[name] = svc;
+  return name;
+}

From 278d027d2322f3404e9979ea3ab1fab5c6196f53 Mon Sep 17 00:00:00 2001
From: Ameen Rashad <7609895+vazra@users.noreply.github.com>
Date: Sun, 11 Oct 2026 02:36:27 -0700
Subject: [PATCH 3/6] fix(ui): delete app dialog says data volumes are kept

---
 docs/concepts/apps-and-services.md              |  2 +-
 docs/operations/archived-apps.md                | 12 +++++++-----
 docs/reference/cli-handwritten.md               |  2 +-
 ui/src/components/SettingsTab.svelte            |  6 +++---
 ui/src/components/__tests__/SettingsTab.test.js | 14 ++++++++++++++
 5 files changed, 26 insertions(+), 10 deletions(-)

diff --git a/docs/concepts/apps-and-services.md b/docs/concepts/apps-and-services.md
index a4a5203e..a1d106a4 100644
--- a/docs/concepts/apps-and-services.md
+++ b/docs/concepts/apps-and-services.md
@@ -44,7 +44,7 @@ Two services, one endpoint, one app named after the directory.
 
 ## Lifecycle
 
-Created when you (or the API) writes the compose file into `apps_dir/<slug>/`. Updated when the file content changes (SHA-256 hash compare). Removed when the directory disappears: the next reconcile pass calls `docker compose down --remove-orphans`. Deploy history is recorded in the `compose_versions` and `deploy_events` tables (migration 009).
+Created when you (or the API) writes the compose file into `apps_dir/<slug>/`. Updated when the file content changes (SHA-256 hash compare). Removed when the directory disappears: the next reconcile pass calls `docker compose down --remove-orphans`. Named volumes are kept, on this path and on Delete (see [Archived apps](/operations/archived-apps/#difference-from-ui-delete)). Deploy history is recorded in the `compose_versions` and `deploy_events` tables (migration 009).
 
 ## App status values
 
diff --git a/docs/operations/archived-apps.md b/docs/operations/archived-apps.md
index 659d3d02..9d5e8c3d 100644
--- a/docs/operations/archived-apps.md
+++ b/docs/operations/archived-apps.md
@@ -78,11 +78,13 @@ The **Delete** action on a live app is a full purge in one step: it tears down c
 
 The archive flow only triggers when the directory disappears **without** going through the Delete action: a manual `rm -rf`, a git sync pulling a delete, or any other out-of-band removal. The reasoning is that intentional UI deletes are deliberate; out-of-band removals are often accidents or git-driven config moves where preserving history is the safer default.
 
-| Path | Containers | App dir | DB row | History | Tombstone |
-|------|------------|---------|--------|---------|-----------|
-| UI Delete | removed | removed | removed | removed | none |
-| Filesystem removal | removed | already gone | retained (`archived_at` set) | retained | written |
-| Purge from archive | already gone | already gone | removed | removed | removed |
+| Path | Containers | App dir | DB row | History | Tombstone | Data volumes |
+|------|------------|---------|--------|---------|-----------|--------------|
+| UI Delete | removed | removed | removed | removed | none | kept |
+| Filesystem removal | removed | already gone | retained (`archived_at` set) | retained | written | kept |
+| Purge from archive | already gone | already gone | removed | removed | removed | kept |
+
+Containers are stopped with `docker compose down` (no `-v`), so named volumes (database files, uploads) are never deleted by SimpleDeploy. To free the space, delete them from the **Docker** page under **Networks & Volumes**, or run `docker volume rm` on the server. An app's volumes are named `simpledeploy-<slug>_<volume>`.
 
 ## Tombstone files
 
diff --git a/docs/reference/cli-handwritten.md b/docs/reference/cli-handwritten.md
index 1061fb14..87f3b621 100644
--- a/docs/reference/cli-handwritten.md
+++ b/docs/reference/cli-handwritten.md
@@ -55,7 +55,7 @@ Remove a deployed app.
 simpledeploy remove --name myapp
 ```
 
-Stops containers, removes network, deletes from store and apps directory.
+Stops containers, removes network, deletes from store and apps directory. Named data volumes are kept; list them with `docker volume ls --filter name=simpledeploy-myapp_` and delete with `docker volume rm`.
 
 ### `simpledeploy list`
 
diff --git a/ui/src/components/SettingsTab.svelte b/ui/src/components/SettingsTab.svelte
index f58f5ab9..0d778f26 100644
--- a/ui/src/components/SettingsTab.svelte
+++ b/ui/src/components/SettingsTab.svelte
@@ -481,8 +481,8 @@
     {#if showDanger}
       <div class="px-5 pb-5 border-t border-red-500/20">
         <div class="pt-4 flex items-center justify-between gap-4">
-          <p class="text-sm text-text-secondary">
-            This will permanently remove <span class="font-medium text-text-primary">{app?.Name}</span> and all its data.
+          <p class="text-sm text-text-secondary" data-testid="delete-app-summary">
+            Permanently removes <span class="font-medium text-text-primary">{app?.Name}</span>: its containers, configuration and history. Its data volumes (databases, uploaded files) are kept on the server.
           </p>
           <Button variant="danger" size="sm" onclick={() => showDeleteModal = true} loading={deleting}>
             Delete App
@@ -502,7 +502,7 @@
 {#if showDeleteModal}
   <Modal
     title="Delete App"
-    message="This will permanently remove {app?.Name} and all its data. This cannot be undone."
+    message="This stops {app?.Name} and permanently removes its containers, configuration and history (deploys, backup schedules, alerts). This cannot be undone. Its data volumes (databases, uploaded files) are kept on the server. To free that space, delete them on the Docker page under Networks & Volumes; their names start with simpledeploy-{slug}_."
     onConfirm={confirmDelete}
     onCancel={() => showDeleteModal = false}
   />
diff --git a/ui/src/components/__tests__/SettingsTab.test.js b/ui/src/components/__tests__/SettingsTab.test.js
index e488bd7f..bc25b3a1 100644
--- a/ui/src/components/__tests__/SettingsTab.test.js
+++ b/ui/src/components/__tests__/SettingsTab.test.js
@@ -204,6 +204,20 @@ describe('SettingsTab', () => {
     return r;
   }
 
+  // Teardown runs `docker compose down` without -v, so named volumes survive.
+  it('says data volumes are kept when deleting the app, and where to remove them', async () => {
+    const r = renderTab();
+    await fireEvent.click(r.getByRole('button', { name: /Danger Zone/i }));
+    expect(r.container.textContent).not.toMatch(/all its data/);
+    expect(r.getByTestId('delete-app-summary').textContent).toMatch(/data volumes .* kept/i);
+    await fireEvent.click(r.getByRole('button', { name: /Delete App/i }));
+    const msg = r.getByRole('dialog').textContent;
+    expect(msg).not.toMatch(/all its data/);
+    expect(msg).toMatch(/kept on the server/);
+    expect(msg).toMatch(/Docker page/);
+    expect(msg).toMatch(/simpledeploy-foo_/);
+  });
+
   it('stays on the page and shows the error when deleting the app fails', async () => {
     routes['DELETE /api/apps/foo'] = () => json({ error: 'compose down failed: daemon unreachable' }, 500);
     const { findByTestId } = await deleteApp();

From 4d915545889ee804e689964e0d49caae07f721c3 Mon Sep 17 00:00:00 2001
From: Ameen Rashad <7609895+vazra@users.noreply.github.com>
Date: Sun, 11 Oct 2026 02:38:06 -0700
Subject: [PATCH 4/6] fix(ui): drop /etc binds from gitea service template
 refused by compose checks

---
 ui/src/lib/__tests__/serviceTemplates.test.js | 19 +++++++++++++++----
 ui/src/lib/serviceTemplates.js                |  8 +++-----
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/ui/src/lib/__tests__/serviceTemplates.test.js b/ui/src/lib/__tests__/serviceTemplates.test.js
index 65036e2e..3bb84195 100644
--- a/ui/src/lib/__tests__/serviceTemplates.test.js
+++ b/ui/src/lib/__tests__/serviceTemplates.test.js
@@ -72,11 +72,11 @@ describe('addServiceToCompose', () => {
   });
 
   it('does not declare bind mounts', () => {
-    const gitea = serviceTemplates.find((t) => t.id === 'gitea');
+    const vols = ['data:/data', './conf:/conf:ro', '/srv/media:/media', '/cache'];
     const compose = { services: {} };
-    addServiceToCompose(compose, gitea);
-    expect(compose.volumes).toEqual({ giteadata: {} });
-    expect(compose.services.gitea.volumes).toEqual(gitea.config.volumes);
+    addServiceToCompose(compose, { id: 'svc', config: { image: 'x:1', volumes: vols } });
+    expect(compose.volumes).toEqual({ data: {} });
+    expect(compose.services.svc.volumes).toEqual(vols);
   });
 
   it('rewrites long syntax sources when renaming', () => {
@@ -167,6 +167,17 @@ describe('serviceTemplates integrity', () => {
       }
     }
   });
+
+  // Host binds like /etc/localtime are refused by the server's compose
+  // security checks (protected system folder), so templates must only use
+  // named volumes.
+  it('volume entries are named volumes, never host bind mounts', () => {
+    for (const t of serviceTemplates) {
+      for (const vol of t.config.volumes || []) {
+        expect(namedVolumeSource(vol), `${t.id}: "${vol}" is not a named volume`).toBeTruthy();
+      }
+    }
+  });
 });
 
 describe('minio service template', () => {
diff --git a/ui/src/lib/serviceTemplates.js b/ui/src/lib/serviceTemplates.js
index 069e895a..8d813c53 100644
--- a/ui/src/lib/serviceTemplates.js
+++ b/ui/src/lib/serviceTemplates.js
@@ -547,11 +547,9 @@ export const serviceTemplates = [
     config: {
       image: 'gitea/gitea:1',
       restart: 'unless-stopped',
-      volumes: [
-        'giteadata:/data',
-        '/etc/timezone:/etc/timezone:ro',
-        '/etc/localtime:/etc/localtime:ro',
-      ],
+      // No /etc/localtime bind: host system folders are refused by the
+      // compose security checks. Gitea logs in UTC.
+      volumes: ['giteadata:/data'],
       environment: {
         USER_UID: '1000',
         USER_GID: '1000',

From 60832e3f9c8a2a9e2468b017bd6bfbe90c7891fd Mon Sep 17 00:00:00 2001
From: Ameen Rashad <7609895+vazra@users.noreply.github.com>
Date: Sun, 11 Oct 2026 02:38:34 -0700
Subject: [PATCH 5/6] refactor(ui): keep template config precedence in
 addServiceToCompose

---
 ui/src/lib/serviceTemplates.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/ui/src/lib/serviceTemplates.js b/ui/src/lib/serviceTemplates.js
index 8d813c53..cf0d357e 100644
--- a/ui/src/lib/serviceTemplates.js
+++ b/ui/src/lib/serviceTemplates.js
@@ -670,11 +670,10 @@ export function namedVolumeSource(entry) {
 // service never shares data with an existing one.
 export function addServiceToCompose(compose, template = null) {
   if (!compose.services) compose.services = {};
-  const blank = !template || template.id === 'blank';
-  const baseName = blank ? 'service' : template.id.replace(/-/g, '_');
+  const baseName = !template || template.id === 'blank' ? 'service' : template.id.replace(/-/g, '_');
   let name = baseName;
   for (let n = 2; compose.services[name]; n++) name = `${baseName}${n}`;
-  const svc = !blank && template.config
+  const svc = template?.config
     ? JSON.parse(JSON.stringify(template.config))
     : { image: '', restart: 'unless-stopped' };
 

From f3f32a10c31cfd9acc5589188925ccd55f87f2a4 Mon Sep 17 00:00:00 2001
From: Ameen Rashad <7609895+vazra@users.noreply.github.com>
Date: Sun, 11 Oct 2026 05:33:08 -0700
Subject: [PATCH 6/6] fix(ui): remove the Woodpecker CI template

Its agent mounts the Docker socket, which deploy refuses for every app (host root access), so the template could not deploy since the compose security checks. The template matrix hid this by accepting a failed deploy for templates without an HTTP probe.
---
 ui/src/lib/__tests__/appTemplates.test.js |  2 +-
 ui/src/lib/appTemplates.js                | 92 +----------------------
 2 files changed, 2 insertions(+), 92 deletions(-)

diff --git a/ui/src/lib/__tests__/appTemplates.test.js b/ui/src/lib/__tests__/appTemplates.test.js
index 1289cd1a..aca2276b 100644
--- a/ui/src/lib/__tests__/appTemplates.test.js
+++ b/ui/src/lib/__tests__/appTemplates.test.js
@@ -362,7 +362,7 @@ describe('appTemplates integrity', () => {
   const categoryIds = new Set(categories.map((c) => c.id));
 
   it('has the expected number of templates', () => {
-    expect(appTemplates.length).toBe(20);
+    expect(appTemplates.length).toBe(19);
   });
 
   it('every template has required fields', () => {
diff --git a/ui/src/lib/appTemplates.js b/ui/src/lib/appTemplates.js
index ff87c9aa..300b9ec7 100644
--- a/ui/src/lib/appTemplates.js
+++ b/ui/src/lib/appTemplates.js
@@ -1558,97 +1558,7 @@ export const appTemplates = [
     ],
   },
 
-  // 19. woodpecker-ci
-  {
-    id: 'woodpecker-ci',
-    name: 'Woodpecker CI',
-    icon: '🪵',
-    category: 'ci',
-    description: 'Simple, container-native CI server with agent.',
-    tags: ['ci', 'woodpecker', 'pipelines', 'build'],
-    nameSuggestion: 'woodpecker',
-    advanced: false,
-    variables: [
-      domainVar,
-      {
-        key: 'admin_user',
-        label: 'Admin username (forge login)',
-        type: 'text',
-        required: true,
-        pattern: '^[a-zA-Z0-9_-]{2,64}$',
-        help: 'Your username on the Git forge (e.g. GitHub/Gitea) that becomes the Woodpecker admin.',
-      },
-      {
-        key: 'agent_secret',
-        label: 'Agent secret',
-        type: 'secret',
-        required: true,
-        hidden: true,
-        generate: { length: 64, charset: 'hex' },
-      },
-    ],
-    compose: {
-      services: {
-        server: {
-          image: 'woodpeckerci/woodpecker-server:v3',
-          restart: 'unless-stopped',
-          environment: {
-            WOODPECKER_OPEN: 'false',
-            WOODPECKER_ADMIN: '{{admin_user}}',
-            WOODPECKER_HOST: 'https://{{domain}}',
-            WOODPECKER_AGENT_SECRET: '{{agent_secret}}',
-          },
-          volumes: ['woodpecker-server-data:/var/lib/woodpecker'],
-          deploy: limits('0.5', '256M'),
-          healthcheck: {
-            test: ['CMD', 'wget', '-qO-', 'http://localhost:8000/healthz'],
-            interval: '30s',
-            timeout: '5s',
-            retries: 3,
-            start_period: '30s',
-          },
-          labels: {
-            'simpledeploy.endpoints.0.domain': '{{domain}}',
-            'simpledeploy.endpoints.0.port': '8000',
-            'simpledeploy.endpoints.0.tls': 'letsencrypt',
-            'simpledeploy.backup.strategy': 'volume',
-            'simpledeploy.backup.schedule': '0 3 * * *',
-            'simpledeploy.backup.target': 'local',
-            'simpledeploy.backup.retention': '14',
-            'simpledeploy.alert.cpu': '85',
-            'simpledeploy.alert.memory': '85',
-          },
-        },
-        agent: {
-          image: 'woodpeckerci/woodpecker-agent:v3',
-          restart: 'unless-stopped',
-          command: 'agent',
-          environment: {
-            WOODPECKER_SERVER: 'server:9000',
-            WOODPECKER_AGENT_SECRET: '{{agent_secret}}',
-            WOODPECKER_MAX_WORKFLOWS: '2',
-          },
-          volumes: ['/var/run/docker.sock:/var/run/docker.sock'],
-          depends_on: { server: { condition: 'service_healthy' } },
-          deploy: limits('0.5', '256M'),
-          healthcheck: {
-            test: ['CMD', '/bin/woodpecker-agent', 'ping'],
-            interval: '30s',
-            timeout: '5s',
-            retries: 3,
-            start_period: '20s',
-          },
-        },
-      },
-      volumes: { 'woodpecker-server-data': {} },
-    },
-    notes: [
-      'The agent mounts the host Docker socket to run pipelines. Treat pipeline access like shell access.',
-      'You must configure a forge (GitHub/Gitea/GitLab) in the server env before first login; see Woodpecker docs.',
-    ],
-  },
-
-  // 20. webhook-tester
+  // 19. webhook-tester
   {
     id: 'webhook-tester',
     name: 'Webhook Tester',