From 00caef473d302c372130f45f76647808aba3bedd Mon Sep 17 00:00:00 2001 From: alexandreferris Date: Thu, 25 Jun 2026 16:00:19 +0200 Subject: [PATCH 1/3] chore: Update secret values for Redis * Remove direct values for Redis * Add values based on secret --- helm/githubapp/templates/statefulset.yaml | 10 ++++++++++ helm/githubapp/values.yaml | 4 ---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/helm/githubapp/templates/statefulset.yaml b/helm/githubapp/templates/statefulset.yaml index 9100f18..3c57757 100644 --- a/helm/githubapp/templates/statefulset.yaml +++ b/helm/githubapp/templates/statefulset.yaml @@ -66,6 +66,16 @@ spec: secretKeyRef: name: {{ .Values.secrets.secretName }} key: WIRE_SDK_CRYPTOGRAPHY_STORAGE_PASSWORD + - name: GHAPP_REDIS_HOST + valueFrom: + secretKeyRef: + name: {{ .Values.redis.secretName }} + key: {{ .Values.redis.hostKey }} + - name: GHAPP_REDIS_PORT + valueFrom: + secretKeyRef: + name: {{ .Values.redis.secretName }} + key: {{ .Values.redis.portKey }} {{- end }} volumeMounts: - name: data diff --git a/helm/githubapp/values.yaml b/helm/githubapp/values.yaml index 1977c38..6358910 100644 --- a/helm/githubapp/values.yaml +++ b/helm/githubapp/values.yaml @@ -66,10 +66,6 @@ env: value: "" - name: GHAPP_SERVER_PORT value: "" - - name: GHAPP_REDIS_HOST - value: "" - - name: GHAPP_REDIS_PORT - value: "" # Health check configuration (latest Kubernetes spec) livenessProbe: From cfff20111e43f03f80777c566501100ec28c868d Mon Sep 17 00:00:00 2001 From: alexandreferris Date: Thu, 25 Jun 2026 16:06:44 +0200 Subject: [PATCH 2/3] chore: Update secret values for Redis * Add missing redis secret in values.yaml --- helm/githubapp/values.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/helm/githubapp/values.yaml b/helm/githubapp/values.yaml index 6358910..77e67db 100644 --- a/helm/githubapp/values.yaml +++ b/helm/githubapp/values.yaml @@ -29,6 +29,11 @@ secrets: secretName: "githubapp-secrets" mountPath: "/etc/secrets" +redis: + secretName: "githubapp-valkey-secrets" + hostKey: "host" + portKey: "port" + # Persistent storage configuration persistence: enabled: true From 36c4cdb568f7d7511a65aa3fb0bd872f3419e746 Mon Sep 17 00:00:00 2001 From: alexandreferris Date: Thu, 25 Jun 2026 16:09:22 +0200 Subject: [PATCH 3/3] chore: Update secret values for Redis * Move redis secret values to its own guarding --- helm/githubapp/templates/statefulset.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/helm/githubapp/templates/statefulset.yaml b/helm/githubapp/templates/statefulset.yaml index 3c57757..50a8c93 100644 --- a/helm/githubapp/templates/statefulset.yaml +++ b/helm/githubapp/templates/statefulset.yaml @@ -66,6 +66,8 @@ spec: secretKeyRef: name: {{ .Values.secrets.secretName }} key: WIRE_SDK_CRYPTOGRAPHY_STORAGE_PASSWORD + {{- end }} + {{ - if .Values.redis }} - name: GHAPP_REDIS_HOST valueFrom: secretKeyRef: @@ -76,7 +78,7 @@ spec: secretKeyRef: name: {{ .Values.redis.secretName }} key: {{ .Values.redis.portKey }} - {{- end }} + {{ - end }} volumeMounts: - name: data mountPath: /opt/githubapp/storage