Skip to content

WP CLI .distignore syntax is changing #139

Open

Description

@BrianHenryIE

Describe the bug

WP CLI's .distignore files will soon support the full .gitignore syntax. Users who write their .distignore file with the larger syntax will encounter issues with 10up/action-wordpress-plugin-deploy.

wp-cli/dist-archive-command#78

Expected behavior

Users will expect a .distignore file to behave the same in both contexts.

Additional context

There are no breaking changes with the existing syntax, the new syntax is a superset (according to the test cases in wp-cli/dist-archive-command).

Activity

  1. moved this from Incoming to To Do in Open Source Practiceon Sep 14, 2023
  2. added this to the 2.3.0 milestone on Sep 14, 2023
  3. claytoncollie commented on Apr 3, 2024

    @claytoncollie

    @BrianHenryIE I opened #148 to address this issue. Please review the pull request and let me know if you have any feedback. Also, I see this repo was last released in 2020 but items are still being merged into the main branch. Was this feature ever released, if not, when will it be?

  4. moved this from To Do to Code Review in Open Source Practiceon Apr 4, 2024
  5. BrianHenryIE commented on Apr 7, 2024

    @BrianHenryIE
    Author

    That release was tagged just now. I’m on holidays right now so haven’t had a chance to test anything yet.

    https://github.com/wp-cli/dist-archive-command/releases/tag/v3.0.0

  6. modified the milestones: 2.3.0, Future Release on Jan 14, 2025
  7. modified the milestones: Future Release, 2.3.1 on Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions