fix(discordbot): ignore replies addressed to other users - #28
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a9d51327-3d5a-4fa9-a80c-5dff4bd1f4ff) |
* feat: harden Discord actor-scoped workflows * fix: make notification claims replay safe * Enforce Discord actor capability scopes * Allow narrowed GitHub credential routes * fix: close Discord workflow authorization gaps * fix: serialize actor policy and retry ingress claims * fix: close Discord continuation boundaries * fix: preserve reviewed bot identities through dispatch * fix: persist reviewed Discord action boundaries * fix(discordbot): ignore replies addressed to other users (#28) * fix: bind Discord bot identities to policies * fix: enforce Discord GitHub App repository scope * fix: enforce Discord GitHub credential boundaries * fix: preserve Discord actor credential policy * fix: reject noncanonical Discord GitHub secrets * fix: validate Discord GitHub rule replacements * fix: reject CIDR rules in Discord policy roles * fix: enforce Discord GitHub policy for all credentials * Keep Discord delivery claims provisional until dispatch * Recover failed Discord claim finalization * Finalize Discord admission after durable handoff * Filter hoisted credentials through Discord policy * Bind Discord capabilities to reviewed roles * Keep Discord policy and execution claims durable * Enforce reviewed Discord capabilities on every update * Allow metadata updates for unassigned Discord actors * Normalize GitHub hosts at the policy boundary * Stabilize provisional Discord admission test * Reconcile Discord actors after role changes * Keep Discord actor policy revocation atomic * Lock Discord policy through actor assignment * Reserve workflow approval idempotency keys * Apply Rust workflow formatting * Bump Centaur chart after parallel merges * Block GitHub broker token reuse in Discord roles * Clarify OAuth credential test fixtures * Avoid persisting credential objects in policy tests
Summary
<@id>/<@!id>syntax instead of adapter-rendered text and cover the policy at unit, admission, and real Chat SDK ingress levelsStack
harden-discord-actor-accessbecause PR Harden Discord actor-scoped access and approvals #27 introduces the actor-scoped Discord admission policy this change extendsValidation
corepack pnpm --filter discordbot run check:typescorepack pnpm --filter discordbot test(161 passed)git diff --checkNote
Low Risk
Narrow ingress filter on unmentioned continuations; direct bot mentions unchanged. Low risk to auth or session integrity.
Overview
Authorized-thread follow-ups no longer append to or steer the Centaur session when the message is an unmentioned reply that canonically mentions another Discord user (
<@id>/<@!id>). Ingress denies those withdirected_to_other_discord_memberafter the existing actor, TTL, and policy checks.Adds
discordMentionRoutingDecisionto classify addressees from raw Gateway content; direct Centaur mentions still win when both the bot and another member appear in the same message.discordGatewayEventFromMessagenow usesraw.content(not adaptermessage.text) so routing uses immutable user IDs.README and unit, admission, and Chat SDK emulate tests cover the behavior.
Reviewed by Cursor Bugbot for commit 4a41292. Bugbot is set up for automated code reviews on this repo. Configure here.