Add undo/redo support for the pattern editor - #85
Closed
tema5002 wants to merge 0 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a ring-buffer-based undo system (ft2_undo.c/h) covering: note edits, pattern insert/delete/length changes, song length/loop start, BPM/speed, channel count and global volume.
Related edits across the pattern editor, position editor, and trim tool now push undo records for their changes, grouped with undoBeginGroup/EndGroup where an action touches more than one cell.
Bound to Ctrl+U and Ctrl+Q in the keyboard handler.
Also a few minor changes I wouldn't open a small not-too-useful PR for:
The help section dedicated to keybinds was not updated.
From what I've tried it works perfectly fine, everything tested on a GNU/Linux system.
If something needs to be done (like renaming some functions) I can push a follow-up commit.