Fix protobuf descriptor collision by delaying cli import in tpu_info#12
Closed
Shuwen-Fang wants to merge 1 commit into
Closed
Fix protobuf descriptor collision by delaying cli import in tpu_info#12Shuwen-Fang wants to merge 1 commit into
Shuwen-Fang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix protobuf descriptor collision by delaying cli import in tpu_info
Root Cause
The
tpu-infopackage imported theclimodule in its top-leveltpu_info/__init__.py. This triggered a chain of imports loading generated proto definitions (liketpu_metric_service.proto), which importgoogle/protobuf/timestamp.proto.When other libraries (like JAX or libtpu) also load these protos, a descriptor collision occurs:
This causes a fatal check failure, crashing the initialization subprocess with exit code
-6(SIGABRT).Fix
Delay importing
cliintpu_info/__init__.pyby commenting it out. It is only needed whentpu-infois run as a CLI tool (which usestpu_info.cli:print_chip_infoentry point and imports it explicitly). Anyone importingtpu_infoas a library (e.g.,tpu_inferenceto get device info) will no longer load the CLI and its proto dependencies, avoiding the collision.Verification
Verified on a TPU VM:
tpu-info==0.7.1(wherecliis imported at top-level).tpu_infoand confirmed they all pass.Bug: b/528372351