Skip to content

fix: restore skill creator script entry points#232

Open
one241 wants to merge 1 commit into
AIPexStudio:mainfrom
one241:fix/skill-creator-quickjs-entry
Open

fix: restore skill creator script entry points#232
one241 wants to merge 1 commit into
AIPexStudio:mainfrom
one241:fix/skill-creator-quickjs-entry

Conversation

@one241

@one241 one241 commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • restore the documented main(args) entry point for all built-in skill creator scripts
  • guard the optional CommonJS fallback so missing entry points report the intended error instead of ReferenceError: module is not defined
  • add regression coverage that keeps all built-in script entry points aligned with the QuickJS runner

Root cause

The scripts exposed _main(args), while the QuickJS runner only invokes main(args) or module.exports. Biome treats the runtime-invoked main function as statically unused and suggests prefixing it with an underscore, so the entry points now include explicit lint suppressions explaining the runtime contract.

Testing

  • pnpm exec biome check ...
  • pnpm -r --if-present typecheck
  • pnpm -r --if-present test
  • pre-push fix end of files and typos hooks

Rename the built-in skill creator entry points from _main to main so the QuickJS runner can invoke them. Guard the CommonJS fallback to preserve the intended missing-entry error and add regression coverage for all built-in scripts.
@buttercannfly

Copy link
Copy Markdown
Collaborator

@jk4235 could you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants