fix: restore skill creator script entry points#232
Open
one241 wants to merge 1 commit into
Open
Conversation
Rename the built-in skill creator entry points from _main to main so the QuickJS runner can invoke them. Guard the CommonJS fallback to preserve the intended missing-entry error and add regression coverage for all built-in scripts.
Collaborator
|
@jk4235 could you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main(args)entry point for all built-in skill creator scriptsReferenceError: module is not definedRoot cause
The scripts exposed
_main(args), while the QuickJS runner only invokesmain(args)ormodule.exports. Biome treats the runtime-invokedmainfunction as statically unused and suggests prefixing it with an underscore, so the entry points now include explicit lint suppressions explaining the runtime contract.Testing
pnpm exec biome check ...pnpm -r --if-present typecheckpnpm -r --if-present testfix end of filesandtyposhooks