Skip to content

arm64: dts: disable unused USB3 AHP controller(1P) - #294

Open
ankitaprasad2206 wants to merge 1 commit into
integ_sp8from
HLK_Test_USB_Fix_1P
Open

arm64: dts: disable unused USB3 AHP controller(1P)#294
ankitaprasad2206 wants to merge 1 commit into
integ_sp8from
HLK_Test_USB_Fix_1P

Conversation

@ankitaprasad2206

Copy link
Copy Markdown
Collaborator

the secondary ASPEED USB3 AHP/vHUB path is not used but remains enabled in the device tree. This results in an extra ASPEED USB controller being enumerated by the OS and causes the Windows Server HLK USB Exposed Port Test to fail.

Tested:

  • Tested on SP7 1P
  • It successfully disables Port A’s PCIe-XHCI-PHY and does not expose it to Windows.

the secondary ASPEED USB3 AHP/vHUB path is not used but
remains enabled in the device tree. This results in an extra
ASPEED USB controller being enumerated by the OS and causes
the Windows Server HLK USB Exposed Port Test to fail.

Tested:
- Tested on SP7 1P
- It successfully disables Port A’s PCIe-XHCI-PHY
   and does not expose it to Windows.

Signed-off-by: ankprasa <ankprasa@amd.com>
&usb3ahp {
status = "okay";
pinctrl-0 = <&pinctrl_usb3axhp_default &pinctrl_usb2axhp_default>;
status = "disabled";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need to disable this explicitly. By default it is disabled in https://github.com/AMDESE/linux-aspeed/blob/integ_sp8/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi#L291. Correct fix would be to delete this node from the board device trees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants