Repository navigation
Stop Dockerfile build steps hiding failed commands - #827
Merged
Merged
Conversation
KavanPrice
added this pull request to stack #833
October 21, 2026 17:54
Most images run their build steps in RUN <<'SHELL' heredocs. Without set -e only the last command's exit status counts, so a step that fails part-way through (npm install, a TypeScript build, apk add, the postgres make) still produces an image. That is how a broken visualiser bundle reached v6.13.0 (#826). Start every heredoc with set -e, and run the sh -x heredocs in acs-service-setup and edge-helm-charts with sh -ex, to match acs-files and acs-git. In the v6.13.0 release build logs no heredoc step other than the visualiser's webpack build was failing, so no image should start failing to build because of this.
KavanPrice
force-pushed
the
kp/dockerfile-set-e
branch
from
October 22, 2026 09:37
7d5f911 to
7bfdef6
Compare
AlexGodbehere
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Most images run their build steps in heredocs without
set -e, so a step that fails part-way through still produces an image. That's how the broken visualiser bundle reached v6.13.0 (#826).RUN <<'SHELL'heredoc now starts withset -e.acs-service-setupandedge-helm-chartsusesh -exinstead ofsh -x.No other heredoc step was failing in the v6.13.0 build, so nothing should start failing to build.