CI: add push actions; update action versions - #459
Open
rgwott wants to merge 1 commit into
Open
Conversation
rgwott
commented
Aug 27, 2026
Contributor
- Trigger tag/deploy workflows automatically on push/PR merge.
- Update action versions to newer ones with Node 24.
- Delete Latest release before creating a new Latest.
rgwott
requested review from
CarolineConcatto,
mgabka,
rockdreamer and
vhscampos
August 27, 2026 08:39
CarolineConcatto
left a comment
Contributor
There was a problem hiding this comment.
Why are ups updating the version?
| jobs: | ||
| build-pdfs: | ||
| if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' | ||
| if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' || (github.event_name == 'push' && github.ref == 'refs/heads/main') |
Contributor
There was a problem hiding this comment.
Why the pdf and the mark downs dont need to check :
github.repository == 'ARM-software/acle'
Contributor
Author
There was a problem hiding this comment.
Those can be executed in any case. The ones that deploy tags and the website have this safeguard so that forks don't execute them (even though they should not succeed).
Contributor
Author
|
@CarolineConcatto We are updating the versions because the image used until now are deprecated, using Node 20 (which has safety flaws). The recommended approach is to use the newer versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.