Conversation
Contributor
|
Hey @ump45nose, please claim issues before workign on them, simply by commenting on the issue. This is important, and have been a review note in your previous PR. At the same time there is an open PR on this that is pending ammendment of review. I will give them priority, and consider yours if they fail to respond or stail for too long. Thanks <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve every bundled skill's
manifest.yamlshort_descriptionso agents usingSkillContext(mode="brief")can route accurately and deterministically:short_descriptionexplicitly states what the skill does and when to use it (trigger context).docs/skills/README.md.CONTRIBUTING.mdspecification forshort_descriptionagent routing.test_manifests_have_valid_short_descriptionsguard intests/test_registry_docs.pyto enforce presence and length constraints (<= 160 chars).Closes #355.
Type of Change
skills/skillware/core/loader, env, adaptersChecklist (all PRs)
Closes #355)python -m black --check .andflake8pass locallypytest tests/test_registry_docs.pyandpytest tests/test_context_and_chains_integration.pypass locallypytest tests/test_registry_docs.pywhen skills, examples index, or agent-loops matrix changedNew or updated skill
Bundle and metadata
skills/<category>/<skill_name>/manifest.yaml:short_descriptionupdated, patch version bumpedValidation
uv run --extra dev --extra gemini pytest tests/test_registry_docs.py tests/test_context_and_chains_integration.py(39 passed, 1 skipped).uv run --extra dev black --check .anduv run --extra dev flake8passed with 0 errors.Drafted with AI assistance; reviewed diff and ran local test suite before submission.