ci: relocate Codecov config, pin actions, add concurrency#12
Open
thc1006 wants to merge 1 commit into
Open
Conversation
- Move .github/workflows/codecov.yml -> .github/codecov.yml. It is a Codecov config file (no on:/jobs:), so Actions parsed it as an invalid workflow and marked a failed run on every commit. The reusable upload-to-codecov.yml stays under workflows/. - Pin third-party actions off moving @main/@master refs to current stable tags (checkout@v7, setup-python@v6, upload-artifact@v7, download-artifact@v8, codecov-action@v7, auto-assign@v3, gh-action-pypi-publish@v1.14.0). - Add concurrency cancel-in-progress to the PR-triggered Tests and Linters workflows (not the scheduled slow one). - Pin ruff (ruff==0.15.20) in the lint workflow for reproducible results. CI-config only; no source changes.
Member
|
Do you want to send this PR to RocketPy directly? We can then pull from RocketPy |
Member
Author
For sure and I will also submit the fixes for the other accelerated optimization issues. I am currently running benchmarks and tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens and fixes the GitHub Actions setup (CI-config only, no source changes).
.github/workflows/codecov.ymlis a Codecov configuration file (it has noon:/jobs:), so Actions treats it as an invalid workflow and records a failed run on every commit. Moved to.github/codecov.yml(content unchanged). The real reusable workflowupload-to-codecov.ymlcorrectly stays underworkflows/.@main/@masterrefs to current stable tags:checkout@v7,setup-python@v6,upload-artifact@v7,download-artifact@v8,codecov-action@v7,auto-assign@v3,gh-action-pypi-publish@v1.14.0(supply-chain / stability hygiene).concurrencycancel-in-progress to the PR-triggeredTestsandLintersworkflows so superseded runs are cancelled (deliberately not added to the scheduled slow workflow).ruff==0.15.20) in the lint workflow for reproducible results.Note:
mastercarries the same misplacedcodecov.yml; a release or cherry-pick clears the permanent failure there too.