Skip to content

Serial channel mode commands never applied the selected mode #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xmutantson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Serial channel mode commands never applied the selected mode #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion hardware/Alternate hardware platforms/src/HFSim_BFD_2_03_Proto/HFSim_BFD_2_03_Proto.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2520,7 +2520,12 @@ void loop()
if (ParseSetSimParameter(strParameter, intSerialCmdMode))
{
Serial.println("OK"); //Serial Command is OK
if (intSerialCmdMode < 5){ ParseSetParameter(strParameter, intSerialCmdMode);}
if (intSerialCmdMode < 5)
{
intMode = intSerialCmdMode;
blnInitialized = false;
ParseSetParameter(strParameter, intSerialCmdMode);
}
}
else { Serial.println("?"); }//Serial Command fail}
}
Expand Down
7 changes: 6 additions & 1 deletion src/HFSim_BFD_2_03/HFSim_BFD_2_03.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2423,7 +2423,12 @@ void loop()
if (ParseSetSimParameter(strParameter, intSerialCmdMode))
{
Serial.println("OK"); //Serial Command is OK
if (intSerialCmdMode < 5){ ParseSetParameter(strParameter, intSerialCmdMode);}
if (intSerialCmdMode < 5)
{
intMode = intSerialCmdMode;
blnInitialized = false;
ParseSetParameter(strParameter, intSerialCmdMode);
}
}
else { Serial.println("?"); }//Serial Command fail}
}
Expand Down
43 changes: 43 additions & 0 deletions tests/test_serial_mode_dispatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import re
import unittest
from pathlib import Path


ROOT = Path(__file__).resolve().parents[1]
FIRMWARES = (
ROOT / "src" / "HFSim_BFD_2_03" / "HFSim_BFD_2_03.ino",
ROOT
/ "hardware"
/ "Alternate hardware platforms"
/ "src"
/ "HFSim_BFD_2_03_Proto"
/ "HFSim_BFD_2_03_Proto.ino",
)


def successful_serial_simulation_dispatch(source: str) -> str:
start = source.index("if (ParseSetSimParameter(strParameter, intSerialCmdMode))")
end = source.index("else { Serial.println(\"?\"); }//Serial Command fail", start)
return source[start:end]


class SerialModeDispatchTest(unittest.TestCase):
def test_channel_mode_commands_apply_and_reinitialize_the_selected_mode(self):
for firmware in FIRMWARES:
with self.subTest(firmware=str(firmware.relative_to(ROOT))):
block = successful_serial_simulation_dispatch(
firmware.read_text(encoding="utf-8")
)
mode_branch = re.search(
r"if\s*\(intSerialCmdMode\s*<\s*5\)\s*\{(?P<body>.*?)\}",
block,
re.DOTALL,
)
self.assertIsNotNone(mode_branch, "missing channel-mode branch")
body = mode_branch.group("body")
self.assertRegex(body, r"\bintMode\s*=\s*intSerialCmdMode\s*;")
self.assertRegex(body, r"\bblnInitialized\s*=\s*false\s*;")


if __name__ == "__main__":
unittest.main()