Repository navigation
docs(positioning): engineer context carries the ADR-0011 line (abilityai/trinity-enterprise#800) - #3260
Merged
Conversation
…011 line (abilityai/trinity-enterprise#800) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…0011 line (abilityai/trinity-enterprise#800) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…facts line (abilityai/trinity-enterprise#800) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trinity-ability
approved these changes
Oct 6, 2026
trinity-ability
left a comment
Contributor
There was a problem hiding this comment.
merge-train: batch validated on train/20261006-1038 (#3270)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes abilityai/trinity-enterprise#800 — the engineer-context half of the ADR-0011 positioning epic (abilityai/trinity-enterprise#796). Independent branch off
dev— the four #796 children touch disjoint files and merge in any order (operator, 2026-10-05). Draft until the chain is in.What
Nine files, copy only, in three commits:
0d1a2dc1):CLAUDE.mdProject Overview line and the:335heading;AGENTS.mdopening line;template.yamldescription(T6 — headline sentence, then "This agent develops it: it implements, reviews and ships changes to the abilityai/trinity repository."),display_nameunchanged (T5).348e4263):docs/memory/requirements.md,docs/memory/requirements/overview.md,docs/memory/architecture.md(title + overview paragraph),docs/onboarding/00-welcome.md(tagline, "What is Trinity?" lead, and the "Learn from experience" bullet deleted — T1),docs/diagrams/01-system-overview.md(intro, lead, and the 83-column box line),docs/trinity-architecture-diagrams.md(**Platform**:label — T3;### 1. Agent Orchestration— T4).a7cf6707): the supporting-facts clause names all three shipped runtimes — "model-agnostic: each agent runs on Claude Code, Gemini CLI or OpenAI Codex" — inCLAUDE.md,docs/memory/architecture.md,docs/memory/requirements/overview.md,docs/diagrams/01-system-overview.md; the same list inAGENTS.mdand the welcome page's multi-runtime bullet.The issue's acceptance grep returns nothing on the branch (14 hits at the base — the 13 table rows plus
docs/trinity-architecture-diagrams.md:570— 0 at the tip).Rulings carried (orchestrator, on the operator's behalf — plan file)
00-welcome.md"📊 Learn from experience — Build semantic memory over time": deleted (planner's recommendation) — a forbidden claim under the epic's rules, and it duplicated "🧠 Remember persistently" two lines above. One bullet inside a table file, not a section removal.01-system-overview.md"the Trinity autonomous agent platform" → "the Trinity platform".trinity-architecture-diagrams.mdlabel**Platform Version**:→**Platform**:.trinity-architecture-diagrams.md### 1. Autonomous Agent Orchestration→### 1. Agent Orchestration— needed for the acceptance grep to reach zero; a mechanism heading, no claim. The Process Engine line below it stays with trinity#2491.template.yamldisplay_namestaysTrinity Platform— it carries no old claim; the issue quotes the description as the problem. Rename is the operator's call.template.yamldescriptionis the hybrid — headline sentence first, then what this agent does — so the fleet map and Library card never show the dev agent as if it were the product.docs/memory/architecture/agent-runtime.md"Three ship today");AGENTS.mdreads "plain Claude Code, Gemini CLI or OpenAI Codex projects". Only lines already rewritten by this branch plus the welcome page's multi-runtime bullet; the welcome page's runtime list further down (no Codex entry) is reported, not restructured.Review + security
/review(claude-fable-5-1, report-only): MERGEABLE AFTER FIXES — 0 critical. Exactly 9 files vs the plan's final reviewed text; welcome bullet deleted cleanly; the 83-column box aligned;template.yamlparses, one key changed, no test reads it;.claude,src/backend/enterpriseuntouched and the rootCLAUDE.mdchange is exactly the ruled lines (no skill-injection text);git merge-treeagainst livedev(493d2a6) clean. I1 (informational, the dropped third runtime) fixed ina7cf6707. I2 (record only): thedescriptionis one physical line inside the|block — the faithful form./cso --diff: 0 findings.Tests
tests/unit/test_2339_testing_docs_consolidated.py+tests/unit/test_2306_architecture_split.py: 42 passed at348e4263and again after the fix. The enterprise-docs-guard pattern: 0 hits over the changed files.template.yamldisplay_namestill'Trinity Platform'.template.yaml. Not run here: the full unit island — CI on this PR.Before merge
/discover-agentsrun shows the new description infleet/system-map.yaml": trinity-pm runs it after this merges and the engineer's workspace syncs; the Library card picks the description up fromtemplate.yamlon its own.display_namekept asTrinity Platform(T5) — say the word if the card should be retitled.dev@ 493d2a6 clean.Handoffs
Abilityai/trinity-devagents/trinity-code-analyzer.md:14("an autonomous agent orchestration and infrastructure platform") — lives in the.claudesubmodule, which this branch never stages; one-line change through trinity-dev's own flow (comment on the issue).docs/memory/feature-flows/agent-to-agent-collaboration.md:24,docs/trinity-architecture-diagrams.md:612,docs/diagrams/03-agent-container.md:7,docs/onboarding/01-getting-started.md:227, the00-welcome.mdruntime list (no Codex entry);src/backend/models.py:226,313stale"claude-code" or "gemini-cli"comment.docs/archive/*hits are history.🤖 Generated with Claude Code