Skip to content

build: upload python wheels for 3.2.* - #5572

Merged
lgritz merged 2 commits into
AcademySoftwareFoundation:mainfrom
lgritz:lg-wheel
Oct 17, 2026
Merged

lgritz merged 2 commits into
AcademySoftwareFoundation:mainfrom
lgritz:lg-wheel

Conversation

@lgritz

@lgritz lgritz commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

There was a hard-coded "only upload the wheels to pypi for 3.1.* or 3.0.* tags." Now that 3.2 is the main release, add it. And remove 3.0, we don't need to keep building python releases for it.

There was a hard-coded "only upload the wheels to pypi for 3.1.* or
3.0.* tags." Now that 3.2 is the main release, add it. And remove 3.0,
we don't need to keep building python releases for it.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@jinhgkim

jinhgkim commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

I know this is only going to be a once-a-year thing with every minor release (only if we forget to make the kind of change this PR makes), but this, to me, seems like a textbook example to include in the release skill. You could ask Claude to amend the existing prepare-patch-release skill to include a check for this kind of issue so that it never slips our minds. One caveat is that it wouldn't run at the minor release itself, but it would catch the issue at the first patch release after.

@jinhgkim

Copy link
Copy Markdown
Collaborator

I had my minion go scout the git history to find out whether this had ever happened in the past, and it reported that it happened for the 3.1 release as well. And Zach even makes a note about it in #4937.

…t forgotten in the future

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz

lgritz commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

but this, to me, seems like a textbook example to include in the release skill. You could ask Claude to amend the existing prepare-patch-release skill to include a check for this kind of issue so that it never slips our minds.

Good suggestion. PR is amended.

@jinhgkim jinhgkim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lgritz
lgritz merged commit 121c8c0 into AcademySoftwareFoundation:main Oct 17, 2026
42 checks passed
@lgritz
lgritz deleted the lg-wheel branch October 18, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants