Repository navigation
Responsive SizedPanel: report the narrow layout's minimum width - #19
Merged
Merged
Conversation
A responsive SizedPanel reported only its wide layout's minimum size, so a window that takes its minimum from its sizer (wx_utils AutoFittingMixin.fit) could never be made narrow enough for the panel to switch: SetSize(150) was refused at the wide minimum. After render, deferred with wx.CallAfter so the window first takes the wide layout's size, the panel measures the narrow layout's minimum width once and sets it as its minimum width (keeping an app-declared min_size where larger). Its best size stays the wide layout's, so the window still opens wide. It then sends its top-level window a size event so a window that re-reads its sizer's minimum on resize picks up the new one. The wrap row's minimum-height pin keeps this width, and leaving wrap mode restores it instead of clearing the minimum. The switch itself is unchanged: it compares the client width with the wide layout's CalcMin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SeWnvjMTaHf6iZhDbaJpDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14, needed by accessibleapps/wx_utils#2.
Once a responsive
SizedPanelhas been laid out, it sets its minimum width to its narrow layout's minimum, while its best size stays the wide one. It then sends the top-level window a size event. A window that takes its minimum from its sizer (wx_utilsAutoFittingMixin) can now be narrowed far enough for the panel to switch layouts.Verified on Windows (wx 4.3.2 msw, private desktop). A form panel (sizer_type "form", narrow "vertical") inside an
AutoFittingMixin+SizedFrame, withfit():fix/fit-minsize-2: the window opens at 273 px wide, and its drag minimum (WM_GETMINMAXINFOptMinTrackSize) becomes 157.SetSize(150)narrows it to 157 and switches the panel to narrow.master, the window stays at a 273 px minimum, so the wx_utils change is needed too.