You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once the NodeSource repo is configured (arm64 and x86_64), apt has to install Ubuntu's real npm package, which conflicts with NodeSource's nodejs. The install then fails for every npm-based server (TypeScript, HTML/CSS/JSON, Tailwind). This comes from the package metadata; I haven't reproduced it with apt.
Suggested fix: install only nodejs (NodeSource bundles npm), and add npm only when command -v npm finds nothing (for example on the Ubuntu nodejs fallback).
2. NodeSource 26.x has no armhf packages
node_26.x/dists/nodistro/main/binary-armhf/Packages has 0 entries. 32-bit devices therefore configure the repo but quietly stay on Ubuntu's Node 18. Either skip NodeSource on armhf or log that fallback.
--installing is only reached from Terminal.install(), which calls uninstall() first and wipes the rootfs. So the ACODE_GENERATED_VERSION / needs_refresh check never runs against an existing install, and a bump from 3 to 5 never updates initrc, acode or the MOTD for current users. terminalGeneratedArtifacts.test.js also asserts that a normal launch never refreshes.
Suggested fix: call refresh_generated_artifacts and write_version_marker on the launch path too. Both are cheap and guarded by needs_refresh, so they only write when the version is stale.
if curl -fsSL "$ACODE_NODESOURCE_SETUP"| bash;then
This runs a remote, unpinned script as root during install. It also installs gnupg and runs its own apt-get update. Writing the three files directly gives a predictable result:
the keyring (/usr/share/keyrings/nodesource.gpg)
/etc/apt/sources.list.d/nodesource.sources
the Pin-Priority: 600 preference
6. allowScripts and CONTRIBUTING changes
The version bumps match package-lock.json, so they're correct, but they aren't related to Ubuntu and would fit better in a separate PR. Also please check that the key "file:../../codemirror-lsp-client" actually matches the dependency spec "@codemirror/lsp-client": "file:codemirror-lsp-client". Otherwise the prepare script stays blocked.
Once the NodeSource repo is configured (arm64 and x86_64), apt has to install Ubuntu's real npm package, which conflicts with NodeSource's nodejs. The install then fails for every npm-based server (TypeScript, HTML/CSS/JSON, Tailwind). This comes from the package metadata; I haven't reproduced it with apt.
Suggested fix: install only nodejs (NodeSource bundles npm), and add npm only when command -v npm finds nothing (for example on the Ubuntu nodejs fallback).
2. NodeSource 26.x has no armhf packages
node_26.x/dists/nodistro/main/binary-armhf/Packages has 0 entries. 32-bit devices therefore configure the repo but quietly stay on Ubuntu's Node 18. Either skip NodeSource on armhf or log that fallback.
--installing is only reached from Terminal.install(), which calls uninstall() first and wipes the rootfs. So the ACODE_GENERATED_VERSION / needs_refresh check never runs against an existing install, and a bump from 3 to 5 never updates initrc, acode or the MOTD for current users. terminalGeneratedArtifacts.test.js also asserts that a normal launch never refreshes.
Suggested fix: call refresh_generated_artifacts and write_version_marker on the launch path too. Both are cheap and guarded by needs_refresh, so they only write when the version is stale.
if curl -fsSL "$ACODE_NODESOURCE_SETUP"| bash;then
This runs a remote, unpinned script as root during install. It also installs gnupg and runs its own apt-get update. Writing the three files directly gives a predictable result:
the keyring (/usr/share/keyrings/nodesource.gpg)
/etc/apt/sources.list.d/nodesource.sources
the Pin-Priority: 600 preference
6. allowScripts and CONTRIBUTING changes
The version bumps match package-lock.json, so they're correct, but they aren't related to Ubuntu and would fit better in a separate PR. Also please check that the key "file:../../codemirror-lsp-client" actually matches the dependency spec "@codemirror/lsp-client": "file:codemirror-lsp-client". Otherwise the prepare script stays blocked.
done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo: