Repository navigation
fix(file-browser): Enforce non-empty input in rename prompt - #2560
Draft
AuDevTist1C wants to merge 1 commit into
Draft
AuDevTist1C wants to merge 1 commit into
AuDevTist1C wants to merge 1 commit into
Conversation
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
bajrangCoder
reviewed
Aug 2, 2026
bajrangCoder
left a comment
bajrangCoder
left a comment
Member
There was a problem hiding this comment.
Enter bypasses the new required validation.
FILE_NAME_REGEX accepts an empty string, so clearing the field enables submission. Pressing Enter runs prompt onsubmit, which resolves "" without checking options.required or hiding the prompt. The rename is cancelled by the caller, but the dialog remains in a resolved, non-functional state.
AuDevTist1C
force-pushed
the
refactor/file-browser-rename-logic
branch
from
August 5, 2026 02:48
8380be3 to
cf04325
Compare
AuDevTist1C
force-pushed
the
refactor/file-browser-rename-logic
branch
from
August 14, 2026 08:49
30873f3 to
6ce70f4
Compare
AuDevTist1C
force-pushed
the
refactor/file-browser-rename-logic
branch
3 times, most recently
from
August 14, 2026 16:15
3cf8973 to
fc1cf4a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
RohitKushvaha01
added
the
needs info / awaiting response
- Enforce `required: true` on the file/folder rename prompt to prevent empty inputs. - Prevent submitting empty string values prior to file operation execution. (AI generated commit message)
AuDevTist1C
changed the title
AuDevTist1C
force-pushed
the
refactor/file-browser-rename-logic
branch
from
October 8, 2026 07:29
fc1cf4a to
8903fc8
Compare
AuDevTist1C
marked this pull request as draft
October 8, 2026 07:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces explicit non-empty input enforcement to the file and folder rename prompt in
fileBrowser.js, preventing users from accidentally submitting empty strings or blank file names.Changes
required: trueconfiguration option to the rename prompt parameter object."") submissions prior to executing file operations.match: config.FILE_NAME_REGEX, eliminating edge cases where empty inputs bypass client-side checks.(PR name and description are AI generated (Gemini 3.6 Flash))