Repository navigation
refactor(file-browser): Consolidate rename logic and error handling - #2958
Open
AuDevTist1C wants to merge 1 commit into
Open
AuDevTist1C wants to merge 1 commit into
AuDevTist1C wants to merge 1 commit into
Conversation
… handling - Unify post-rename side effects (recents update, editor tab URI sync, tree state, success toast, reload) across standard and Termux filesystem paths. - Wrap standard filesystem rename execution inside the master try-catch block to gracefully capture errors. (AI generated commit message)
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the file/folder rename control flow in
fileBrowser.jsto eliminate code duplication across standard and Termux storage backends while unifying asynchronous error handling.Changes
1. Refactor and Deduplicate
renameFileFlowrenameFile(newname)following the DRY (Don't Repeat Yourself) design principle.isTermuxUrl(url)) maintained duplicate state updates (recents.removeFile,recents.addFile,editorManager.getFile,openFolder.renameItem,toast, andreload()) and exited early via return statements.newUrlwithin a unifiedif / elseblock. Successful executions fall through to a single, centralized set of state updates and UI refreshes.2. Unified Error Handling
fs.renameTo(newname)) inside the mastertry...catchblock to handle exceptions consistently alongside Termux operations.(PR name and description are AI generated (Gemini 3.6 Flash))