Support numpy2 on windows#306
Merged
Merged
Conversation
Member
Author
|
@MMathisLab , could you have a quick look? -- remove one windows-specific restriction that got fixed upstream, and add one numpy-specific (temporary) restriction to fix our docs build. |
MMathisLab
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past, there was a compatibility issue on windows with numpy 2. It seems this issue is fixed now and there is interest to use numpy 2 on windows.
Parallel to this effort, numpy 2.5 was released. This breaks our docs build pipeline at one point. As a temporary measure we can expect to lift in a few weeks, I am pinning the max numpy version < 2.5.
Fix #303
Fix #305