Repository navigation
ENG-3405: Run the API tests on GitHub Actions - #116
Merged
Merged
Conversation
Replaces the Jenkins job "Test AirConsole API". ci/jenkins.groovy stays until the Jenkins job is disabled after the first green master run.
Declare contents: write, so the repo default token can be set to read-only. Pin the runner to ubuntu-24.04, move checkout and setup-python to v7 and actions-gh-pages to v4.
marc-n-dream
reviewed
Oct 6, 2026
marc-n-dream
reviewed
Oct 6, 2026
| pull_request: | ||
|
|
||
| permissions: | ||
| contents: read |
Contributor
There was a problem hiding this comment.
what do we need the read permission for?
The information in the checkout we have and that should be the only thing we need, right?
Contributor
Author
There was a problem hiding this comment.
As discussed we need just in case global repo / org permissions would change, now it allows everything or every workflow by default and we're narrowing down the permissions here to be future-proof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Jenkins job "Test AirConsole API" with a GitHub Actions workflow, so Jenkins can be shut down without losing these tests.
Test AirConsole APIworkflow runs the six Jasmine runners through Playwright onubuntu-24.04, on every branch push and every pull request (a PR commit from this repo runs twice), with a read-only token and no secrets..nvmrc, pnpm 11.13.1 in the workflow, andci/pnpm-lock.yamlis committed forpnpm install --frozen-lockfile.contents: write, run onubuntu-24.04, and useactions/checkout@v7,actions/setup-python@v7andpeaceiris/actions-gh-pages@v4.Testing: locally in
ci/,pnpm install --frozen-lockfilepassed andnpx playwright test --project chromiumgave 6 passed.actionlinton the three workflows passed. Not run on GitHub yet.Out of scope: deleting
ci/jenkins.groovy, which follows once the firstmasterrun is green and the Jenkins job is disabled.Refs: https://ndream.atlassian.net/browse/ENG-3405