Skip to content

fix(ios): reset the layer transform before setting a frame under an animation #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farfromrefug merged 1 commit into from
Oct 2, 2026
Merged

fix(ios): reset the layer transform before setting a frame under an animation #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/core/ui/core/view/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export class View extends ViewCommon {
*/
private _modalAnimatedOptions: Array<boolean>;
private _isLaidOut = false;
private _isTransformed = false;
private _privateFlags: number = PFLAG_LAYOUT_REQUIRED | PFLAG_FORCE_LAYOUT;
private _cachedFrame: CGRect;
private _suspendCATransaction = false;
Expand Down Expand Up @@ -100,7 +99,6 @@ export class View extends ViewCommon {

this._cachedFrame = null;
this._isLaidOut = false;
this._isTransformed = false;
}

public requestLayout(): void {
Expand Down Expand Up @@ -240,7 +238,9 @@ export class View extends ViewCommon {
public _modifyNativeViewFrame(nativeView: UIView, frame: CGRect): void {
let transform: CATransform3D;

if (this._isTransformed) {
// the layer's own transform: an animation sets it before the view's properties, which then
// match and skip updateNativeTransform, so a flag kept there would still read untransformed
if (!CATransform3DEqualToTransform(nativeView.layer.transform, CATransform3DIdentity)) {
// Always set identity transform before setting frame
transform = nativeView.layer.transform;
nativeView.layer.transform = CATransform3DIdentity;
Expand Down Expand Up @@ -487,7 +487,6 @@ export class View extends ViewCommon {
if (nativeView.outerShadowContainerLayer) {
nativeView.outerShadowContainerLayer.transform = transform;
}
this._isTransformed = this.nativeViewProtected && !CATransform3DEqualToTransform(this.nativeViewProtected.transform3D, CATransform3DIdentity);

if (!isInTheMiddleOfAnimation) {
CATransaction.setDisableActions(false);
Expand Down
Loading