Repository navigation
feat(ios): let App_Resources/Catalyst/build.xcconfig override the iOS one - #7
Merged
Merged
Conversation
… one A Catalyst build only read App_Resources/iOS/build.xcconfig, and passes the deployment target on the xcodebuild command line, so no xcconfig could give Catalyst a different one. The Catalyst file is now merged first, and the settings passed on the command line read it before the iOS one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
ios-project-servicetests, identical with and without this change (DI setup); 54 pass.What is the current behavior?
A Mac Catalyst build only reads
App_Resources/iOS/build.xcconfig(normalizedPlatformNameisiOSfor catalyst). The deployment target is also passed on the xcodebuild command line, which beats any xcconfig. So an app cannot give Catalyst a different deployment target than iOS (or any other Catalyst-only setting). Hit in alpimaps: theSimulatorCameraSPM package needs Catalyst 14 while iOS stays 12.What is the new behavior?
App_Resources/Catalyst/build.xcconfiginto the plugins xcconfig before the iOS one, so its values winIPHONEOS_DEPLOYMENT_TARGET,DEVELOPMENT_TEAM,NS_SWIFTUI_BOOT,SWIFT_ENABLE_EXPLICIT_MODULES) read the Catalyst file first, then the platform one (unchanged for iOS/visionOS)Verified with
ns prepare catalystin alpimaps: merged xcconfig hasIPHONEOS_DEPLOYMENT_TARGET = 14.0, and the app builds and runs on Mac.Note: the merge prints
Ignoring IPHONEOS_DEPLOYMENT_TARGET = 12.0 from App_Resources/iOS/build.xcconfig, which is expected (Catalyst value wins).🤖 Generated with Claude Code