Repository navigation
fix(bundler): pass env.catalyst when bundling for Mac Catalyst - #8
Merged
Merged
Conversation
A Catalyst build bundles as iOS (its platform data says ios), so the app's webpack config could not tell the two apart. Catalyst builds now also get env.catalyst, which an app can turn into a compile-time flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
ns run/prepare catalystbundles as iOS:buildEnvDataonly setsenv.ios, so an app's webpack config cannot tell a Mac Catalyst bundle from an iOS one (needed for a compile-time__CATALYST__flag).What is the new behavior?
Catalyst builds also get
env.catalyst = trueinbuildEnvData. iOS and Android are unchanged.Verified in alpimaps:
ns run catalystwithDefinePlugin({ __CATALYST__: !!env.catalyst })compiles the Catalyst-only code in (iOS builds were not re-run:env.catalystis simply absent there).🤖 Generated with Claude Code