Repository navigation
Add French and German UI languages - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vers now supports French and German alongside Italian and English across the interface, accessibility labels, errors, notifications and roll explanations. The language control exposes all four languages and uses a compact native menu on narrow screens. Preferences persist across reloads and synchronize across tabs; page metadata and number/date locales follow the selection.
The new catalogs cover all 518 translation keys. Character names, notes, saving-throw identifiers and stored roll payloads stay unchanged. The ADV/DIS tooltip also translates its base-dice fragment.
Validation: production build, lint and all 133 tests passed; dependency audit found no vulnerabilities; file/secret scanning passed. New tests cover complete catalogs/placeholders, native selector labels, persistence/cross-tab updates, blocked storage, canonical stat edits and unchanged ADV/DIS results. Browser checks on a local demo covered FR/DE labels, preserved selection and notes, an unchanged real roll across languages, reload persistence and the compact selector at 390px.