Skip to content

feat: enable loongarch64 LSX SIMD feature gate - #18

Closed
fanta0625 wants to merge 1 commit into
Alexhuszagh:mainfrom
fanta0625:loongarch64-feature-gate
Closed

fanta0625 wants to merge 1 commit into
Alexhuszagh:mainfrom
fanta0625:loongarch64-feature-gate

Conversation

@fanta0625

Copy link
Copy Markdown

The loongarch64 LSX SIMD code already exists in
src/binary16/arch/loongarch64.rs and is properly gated behind cfg(target_arch = "loongarch64"), but building on loongarch64 with nightly Rust fails because the crate root is missing:

#![feature(stdarch_loongarch)]

Without this, core::arch::loongarch64 intrinsics raise E0658 even on nightly, since stdarch_loongarch is still an unstable feature (Rust issue #117427).

The loongarch64 LSX SIMD code already exists in
src/binary16/arch/loongarch64.rs and is properly gated behind
cfg(target_arch = "loongarch64"), but building on loongarch64
with nightly Rust fails because the crate root is missing:

  #![feature(stdarch_loongarch)]

Without this, core::arch::loongarch64 intrinsics raise E0658 even
on nightly, since stdarch_loongarch is still an unstable feature
(Rust issue #117427).

@Alexhuszagh Alexhuszagh left a comment •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on the stable channel: this must be done on a nightly channel and therefore would break existing builds. Since we do have rust_version as a dependency we can fix this, however.

Alexhuszagh added a commit that referenced this pull request Aug 13, 2026
This gates feature detection to the nightly compiler and those with Rust >= 1.89.

Supersedes #18
Closes #27
Alexhuszagh added a commit that referenced this pull request Aug 13, 2026
This gates feature detection to the nightly compiler and those with Rust >= 1.89.

Supersedes #18
Closes #27
Alexhuszagh added a commit that referenced this pull request Aug 13, 2026
This gates feature detection to the nightly compiler and those with Rust >= 1.89.

Supersedes #18
Closes #27
Alexhuszagh added a commit that referenced this pull request Aug 13, 2026
This gates feature detection to the nightly compiler and those with Rust >= 1.89.

Supersedes #18
Closes #27
Alexhuszagh added a commit that referenced this pull request Aug 13, 2026
This gates feature detection to the nightly compiler and those with Rust >= 1.89.

Supersedes #18
Closes #27
Alexhuszagh added a commit that referenced this pull request Aug 13, 2026
This gates feature detection to the nightly compiler and those with Rust >= 1.89.

Supersedes #18
Closes #27
@Alexhuszagh

Copy link
Copy Markdown
Owner

Closed and superseded by #28. I will add you to the contributors in the CHANGELOG for reporting this in the upcoming release. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants