Skip to content

ci: create a quality assurance workflow - #173

Open
robertodr wants to merge 34 commits into
chore-dev-single-build-pathfrom
ci-split-qa-jobs
Open

ci: create a quality assurance workflow#173
robertodr wants to merge 34 commits into
chore-dev-single-build-pathfrom
ci-split-qa-jobs

Conversation

@robertodr

@robertodr robertodr commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary

Separate quality assurance jobs from testing.

Changes

  • Split code coverage from test.yml to qa-analysis.yml
  • Split sonarqube from test.yml to qa-analysis.yml

Checklist

  • Tests added or updated to cover the changes
  • Documentation updated (docstrings, docs/, CONTRIBUTING.md) if needed
  • CHANGELOG / release notes updated if applicable

AI/LLM disclosure

  • I did not use LLM tooling, or used it only privately for ideation
  • I used the following tool to help write this PR description:
  • I used the following tool to generate or modify code:

Important

By opening this PR I confirm that I have read CONTRIBUTING.md and I agree to the terms of the Contributor License Agreement.

Warning

If you're contributing on behalf of your employer, contact cla@algorithmiq.fi to arrange a Corporate CLA.


This is part 2 of 3 in a stack made with GitButler:

@github-actions

Copy link
Copy Markdown

Docs preview: https://pr-173.monoprop-docs.pages.dev

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (847b50f) to head (d582e87).
⚠️ Report is 53 commits behind head on chore-dev-single-build-path.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           chore-dev-single-build-path     #173       +/-   ##
================================================================
+ Coverage                        84.66%   95.31%   +10.64%     
================================================================
  Files                               59       14       -45     
  Lines                             4239      704     -3535     
  Branches                          1497       88     -1409     
================================================================
- Hits                              3589      671     -2918     
+ Misses                             254       20      -234     
+ Partials                           396       13      -383     
Flag Coverage Δ
cpp 95.31% <ø> (+12.76%) ⬆️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@robertodr
robertodr force-pushed the chore-dev-single-build-path branch from 2587fab to 802a56f Compare July 31, 2026 11:13
@robertodr
robertodr force-pushed the ci-split-qa-jobs branch 3 times, most recently from 818dabd to 6c119df Compare July 31, 2026 12:30
@robertodr
robertodr force-pushed the chore-dev-single-build-path branch from cffecae to 01cf9c8 Compare July 31, 2026 13:39
@robertodr
robertodr force-pushed the chore-dev-single-build-path branch from 01cf9c8 to 73da1b3 Compare July 31, 2026 17:35
@robertodr
robertodr force-pushed the chore-dev-single-build-path branch from 73da1b3 to edd6db8 Compare August 1, 2026 17:49
@robertodr
robertodr force-pushed the chore-dev-single-build-path branch from edd6db8 to 88dfbf7 Compare August 1, 2026 17:52
When needed, can be run as uvx gcovr, using an ephemeral environment
There is a single job running on ubuntu-26.04 with python 3.11
collecting coverage information from:
* Python tests
* C++ unit tests
* line hits from calling the C++ compiled code from the Python API
Thus avoiding a rebuild when invoking pytest
Fallout from removing most of the cmake presets
Needs lcov format, plus some workarounds, to merge the Python and C++
results.
@robertodr
robertodr force-pushed the chore-dev-single-build-path branch from 88dfbf7 to 72965c2 Compare August 2, 2026 14:01
@robertodr

Copy link
Copy Markdown
Member Author

apologies: as you can see the history got completely mangled (34 commits, while it should be 7 or so) I'm learning how to use stacked PRs...

@sonarqubecloud

sonarqubecloud Bot commented Aug 2, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants