Skip to content

[O2B-1595] Add filterable overview page class#2172

Merged
graduta merged 26 commits into
mainfrom
improv/O2B-1595/add-filterable-overview-page-class
Jun 19, 2026
Merged

[O2B-1595] Add filterable overview page class#2172
graduta merged 26 commits into
mainfrom
improv/O2B-1595/add-filterable-overview-page-class

Conversation

@NarrowsProjects

@NarrowsProjects NarrowsProjects commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

I DON'T have JIRA ticket

  • explain what this PR does
  • if it is a new feature, explain how you plan to use it
  • tests are added
  • documentation was updated or added

A new class called FilterableOverviewPageModel has been created.
All classes that previously instantiated a FilteringModel in them have now been changed to extend this class instead.

Notable changes for users:

  • N/A

Notable changes for developers:

  • The FilterableOverviewPageModel class by default fetches it's data immediately.
  • If you wish to fetch it using debounce, you'll have to set the variable 'fetchImediately' to true
  • The debounce functionallity from all overview pages has been removed
    • The reason is that the pages define the functionallity, but don't use it*
    • * LogsOverview does use it, but exclusively for sorting, for which the effective change is very minimal.

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Jun 19, 2026
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.00%. Comparing base (0d85633) to head (33c084b).

Files with missing lines Patch % Lines
lib/public/models/FilterableOverviewPageModel.js 0.00% 32 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 6 Missing ⚠️
...dOverview/AnchoredSimulationPassesOverviewModel.js 0.00% 5 Missing ⚠️
...rview/SimulationPassesPerLhcPeriodOverviewModel.js 0.00% 5 Missing ⚠️
lib/public/models/OverviewModel.js 0.00% 2 Missing ⚠️
.../Environments/Overview/EnvironmentOverviewModel.js 0.00% 2 Missing ⚠️
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 2 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 2 Missing ⚠️
...s/QcFlagTypes/Overview/QcFlagTypesOverviewModel.js 0.00% 2 Missing ⚠️
...ews/lhcPeriods/Overview/LhcPeriodsOverviewModel.js 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2172      +/-   ##
==========================================
+ Coverage   45.65%   46.00%   +0.34%     
==========================================
  Files        1038     1039       +1     
  Lines       17318    17189     -129     
  Branches     3155     3138      -17     
==========================================
  Hits         7907     7907              
+ Misses       9411     9282     -129     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta graduta changed the title Add filterable overview page class [O2B-1595] Add filterable overview page class Jun 19, 2026
Comment thread lib/public/models/FilterableOverviewPageModel.js
Comment thread lib/public/views/Runs/Overview/RunsOverviewModel.js
Comment thread lib/public/views/lhcPeriods/Overview/LhcPeriodsOverviewModel.js Outdated
Comment thread lib/public/views/Logs/Overview/LogsOverviewModel.js Outdated
Comment thread lib/public/models/FilterableOverviewPageModel.js
@NarrowsProjects NarrowsProjects requested a review from graduta June 19, 2026 15:09
@graduta graduta merged commit 838e6a8 into main Jun 19, 2026
55 of 59 checks passed
@graduta graduta deleted the improv/O2B-1595/add-filterable-overview-page-class branch June 19, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants