[PWGHF] TrackIndexSkimCreator: hoist collision-invariant slices out of the 2/3-prong loops#16666
Open
ktf wants to merge 1 commit into
Open
[PWGHF] TrackIndexSkimCreator: hoist collision-invariant slices out of the 2/3-prong loops#16666ktf wants to merge 1 commit into
ktf wants to merge 1 commit into
Conversation
ktf
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
vkucera
requested changes
Jun 15, 2026
vkucera
left a comment
vkucera
left a comment
Collaborator
There was a problem hiding this comment.
Please add the file name in the PR title to specify the scope of the changes.
ktf
changed the title
Member
Author
|
@vkucera improved. Actual validation of the code done at https://alimonitor.cern.ch/hyperloop/view-wagon/57243/test-statistics |
Collaborator
I think you confused it with another PR. |
Member
Author
|
yes, indeed. |
Member
Author
|
The description was meant for #16663 |
ktf
changed the title
Collaborator
|
Error while checking build/O2Physics/o2 for 0c38cad at 2026-06-21 07:28: Full log here. |
Member
Author
|
What is this missing to be merged? |
Collaborator
|
@ktf Has this been validated, i.e. before-vs-after comparison of output and performance? |
Member
Author
|
I was actually hoping for you (PWGHF) to do it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In run2And3Prongs the negative-track index slice was rebuilt inside the positive-track loop, and the D* soft-pion slices inside the (pos,neg) pair body, though all three depend only on the collision. Hoist the neg-track slice to collision scope, and lazily materialize the soft-pion slices once per collision via std::optional. Pure loop-invariant code motion.