[ALICE3] Implementation of prefilter and PID for ALICE 3#16693
Merged
Conversation
rbailhac
requested review from
alibuild,
hscheid,
jesgum and
njacazio
as code owners
|
O2 linter results: ❌ 61 errors, |
github-actions
Bot
changed the title
Collaborator
|
Error while checking build/O2Physics/staging for 3558e99 at 2026-06-16 16:24: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 3558e99 at 2026-06-16 16:28: Full log here. |
Collaborator
Author
njacazio
approved these changes
Jun 17, 2026
vkucera
reviewed
Jun 22, 2026
Comment on lines
+20
to
34
| #include "ALICE3/DataModel/prefilterDilepton.h" | ||
| #include "ALICE3/DataModel/tracksAlice3.h" | ||
| #include "Common/DataModel/TrackSelectionTables.h" | ||
|
|
||
| #include <CommonConstants/PhysicsConstants.h> | ||
| #include <Framework/ASoAHelpers.h> | ||
| #include <Framework/AnalysisDataModel.h> | ||
| #include <Framework/AnalysisHelpers.h> | ||
| #include <Framework/AnalysisTask.h> | ||
| #include <Framework/Configurable.h> | ||
| #include <Framework/HistogramRegistry.h> | ||
| #include <Framework/HistogramSpec.h> | ||
| #include <Framework/InitContext.h> | ||
| #include <Framework/O2DatabasePDGPlugin.h> | ||
| #include <Framework/OutputObjHeader.h> | ||
| #include <Framework/runDataProcessing.h> | ||
|
|
||
| #include <Math/Vector4D.h> // IWYU pragma: keep (do not replace with Math/Vector4Dfwd.h) | ||
| #include <Math/Vector4Dfwd.h> | ||
| #include <THnSparse.h> | ||
| #include <TMath.h> | ||
| #include <Math/Vector4D.h> | ||
|
|
||
| #include <cstdint> | ||
| #include <cstdlib> | ||
| #include <vector> |
Collaborator
There was a problem hiding this comment.
This is wrong. How did you produce these changes?
Collaborator
|
@njacazio Please do not merge PRs with suspicious changes of includes. |
vkucera
reviewed
Jun 22, 2026
Comment on lines
+17
to
+37
| #include "ALICE3/DataModel/OTFCollision.h" | ||
| #include "ALICE3/DataModel/OTFRICH.h" | ||
| #include "ALICE3/DataModel/OTFTOF.h" | ||
| #include "ALICE3/DataModel/prefilterDilepton.h" | ||
| #include "ALICE3/DataModel/tracksAlice3.h" | ||
| #include "Common/DataModel/TrackSelectionTables.h" | ||
|
|
||
| #include <CommonConstants/PhysicsConstants.h> | ||
| #include <Framework/ASoAHelpers.h> | ||
| #include <Framework/AnalysisDataModel.h> | ||
| #include <Framework/AnalysisTask.h> | ||
| #include <Framework/HistogramRegistry.h> | ||
| #include <Framework/O2DatabasePDGPlugin.h> | ||
| #include <Framework/runDataProcessing.h> | ||
| #include <MathUtils/Utils.h> | ||
|
|
||
| #include <Math/GenVector/VectorUtil.h> | ||
| #include <Math/Vector4D.h> | ||
|
|
||
| #include <unordered_map> | ||
| #include <vector> |
vkucera
reviewed
Jun 22, 2026
Comment on lines
+13
to
+15
| /// \file collisionExtra.h | ||
| /// \author David Dobrigkeit Chinellato | ||
| /// \since 11/05/2023 |
Collaborator
There was a problem hiding this comment.
Where does this come from?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First implementation of prefilter and PID for ALICE 3 FAT (before introducing a method to use resolution maps from ACTS and PID efficiency from full simulation)