[PWGHF] treeCreatorDstarSpinAlignMixing: Adding new task for local mix candidate analysis in Dstar spin alignment measurement. by Mingze129 · Pull Request #16721 · AliceO2Group/O2Physics

Mingze129 · 2026-06-17T15:23:20Z

Add a new task to obtain the candidates information required for local mixed-event analysis.

…ent measurement.

github-actions · 2026-06-17T15:23:43Z

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#16721

fgrosa

Hi @Mingze129 thanks a lot! The implementation looks good to me, I just have a few minor comments (see below)

vkucera · 2026-06-18T11:05:12Z

@Mingze129 can you please clarify what this workflow is supposed to produce? From the name and path, it is not clear whether it's a task, a candidate creator, or a tree creator.

Mingze129 · 2026-06-18T11:54:27Z

@Mingze129 can you please clarify what this workflow is supposed to produce? From the name and path, it is not clear whether it's a task, a candidate creator, or a tree creator.

@vkucera Thank you for you comments on this draft.

I need this task to produce derived data for local mixed-event analysis.

I marked it as Draft mainly for two reasons. First, I would like to develop it together with Fabrizio. Second, I am not yet sure how this script should be named, where it should be placed in the repository, or whether we will eventually want to add a complete online mixed-event analysis workflow in the future.

My original plan was to discuss these details with Fabrizio after the script was completed and had passed the tests, and then change the status to Ready. Since you have raised the question now, I look forward to hearing your suggestions and would greatly appreciate any guidance you can offer.

fgrosa · 2026-06-18T12:55:53Z

@Mingze129 can you please clarify what this workflow is supposed to produce? From the name and path, it is not clear whether it's a task, a candidate creator, or a tree creator.

@vkucera Thank you for you comments on this draft.

I need this task to produce derived data for local mixed-event analysis.

I marked it as Draft mainly for two reasons. First, I would like to develop it together with Fabrizio. Second, I am not yet sure how this script should be named, where it should be placed in the repository, or whether we will eventually want to add a complete online mixed-event analysis workflow in the future.

My original plan was to discuss these details with Fabrizio after the script was completed and had passed the tests, and then change the status to Ready. Since you have raised the question now, I look forward to hearing your suggestions and would greatly appreciate any guidance you can offer.

Hi @Mingze129, I think you can rename it treeCreatorDstarSpinAlignMixing, move it to the D2H/TableProducer folder and once implemented my few comments, it looks good to me (provided that you tested it locally). Many thanks!

vkucera · 2026-06-18T13:06:48Z

@Mingze129 can you please clarify what this workflow is supposed to produce? From the name and path, it is not clear whether it's a task, a candidate creator, or a tree creator.

@vkucera Thank you for you comments on this draft.
I need this task to produce derived data for local mixed-event analysis.
I marked it as Draft mainly for two reasons. First, I would like to develop it together with Fabrizio. Second, I am not yet sure how this script should be named, where it should be placed in the repository, or whether we will eventually want to add a complete online mixed-event analysis workflow in the future.
My original plan was to discuss these details with Fabrizio after the script was completed and had passed the tests, and then change the status to Ready. Since you have raised the question now, I look forward to hearing your suggestions and would greatly appreciate any guidance you can offer.

Hi @Mingze129, I think you can rename it treeCreatorDstarSpinAlignMixing, move it to the D2H/TableProducer folder and once implemented my few comments, it looks good to me (provided that you tested it locally). Many thanks!

Thanks @Mingze129 @fgrosa . That sounds reasonable.

already did

vkucera · 2026-06-22T11:57:36Z

+      massDStar = candidate.invMassAntiDstar();
+    }
+    etaSoftPi = RecoDecay::eta(std::array{candidate.pxSoftPi(), candidate.pySoftPi(), candidate.pzSoftPi()});
+    phiSoftPi = RecoDecay::phi(std::array{candidate.pxSoftPi(), candidate.pySoftPi(), candidate.pzSoftPi()});


You only need the px and py to get phi.

vkucera

Please don't ignore the warning.

vkucera · 2026-06-22T12:00:15Z

+    auto trackProng0 = candidate.template prong0_as<Trk>();
+    auto trackProng1 = candidate.template prong1_as<Trk>();
+    auto trackProng2 = candidate.template prongPi_as<Trk>();


Suggested change

auto trackProng0 = candidate.template prong0_as<Trk>();

auto trackProng1 = candidate.template prong1_as<Trk>();

auto trackProng2 = candidate.template prongPi_as<Trk>();

auto const& trackProng0 = candidate.template prong0_as<Trk>();

auto const& trackProng1 = candidate.template prong1_as<Trk>();

auto const& trackProng2 = candidate.template prongPi_as<Trk>();

vkucera · 2026-06-22T12:01:12Z

+    auto trackProng1 = candidate.template prong1_as<Trk>();
+    auto trackProng2 = candidate.template prongPi_as<Trk>();
+    getTrackingInfos(std::vector{trackProng0, trackProng1, trackProng2}, absEtaTrackMin, numItsClsMin, numTpcClsMin);
+    std::array<float, 3> const Qvector = getQvec(collision, qVecDetector.value);


Don't force the assigned type.

Suggested change

std::array<float, 3> const Qvector = getQvec(collision, qVecDetector.value);

auto const Qvector = getQvec(collision, qVecDetector.value);

vkucera · 2026-06-22T12:01:58Z

+  void init(InitContext const&)
+  {
+  }


vkucera · 2026-06-22T12:02:33Z

+  /// prongTracks is the vector of daughter tracks
+  /// etaMin is the minimum eta
+  /// nItsClsMin is the minumum number of clusters in ITS
+  /// nTpcClsMin is the minumum number of clusters in TPC


You don't mention what it does.

vkucera · 2026-06-22T12:03:30Z

+    }
+  }
+
+  template <typename CollType, typename T, typename Trk, typename BcType>


Use meaningful type names.

Adding new task for local mix candidate analysis in Dstar spin alignm…

2e047f7

…ent measurement.

github-actions Bot added the pwghf PWG-HF label Jun 17, 2026

Please consider the following formatting changes

b03fd1d

alibuild mentioned this pull request Jun 17, 2026

Please consider the following formatting changes to #16721 Mingze129/O2Physics#26

Merged

Mingze129 and others added 2 commits June 17, 2026 17:24

Merge pull request #26 from alibuild/alibot-cleanup-16721

cb6ec4b

Please consider the following formatting changes to AliceO2Group#16721

Use UpperCamelCase for names of O2 columns

958da4a

vkucera reviewed Jun 18, 2026

View reviewed changes

Comment thread PWGHF/D2H/Tasks/CMakeLists.txt Outdated

fgrosa previously requested changes Jun 18, 2026

View reviewed changes

update

be2d408

Mingze129 changed the title ~~[PWGHF] taskMixingDstarCandTreeCreator: Adding new task for local mix candidate analysis in Dstar spin alignment measurement.~~ [PWGHF] treeCreatorDstarSpinAlignMixing: Adding new task for local mix candidate analysis in Dstar spin alignment measurement. Jun 18, 2026

Mingze129 marked this pull request as ready for review June 22, 2026 07:10

Mingze129 requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, gluparel, hahassan7, jpxrk, mfaggin, mmazzilli, singhra1994, stefanopolitano and zhangbiao-phy as code owners June 22, 2026 07:10

zhangbiao-phy approved these changes Jun 22, 2026

View reviewed changes

zhangbiao-phy enabled auto-merge (squash) June 22, 2026 11:39

zhangbiao-phy merged commit f8b07da into AliceO2Group:master Jun 22, 2026
16 checks passed

vkucera reviewed Jun 22, 2026

View reviewed changes

	std::array<float, 3> const Qvector = getQvec(collision, qVecDetector.value);
	auto const Qvector = getQvec(collision, qVecDetector.value);

Conversation

Mingze129 commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fgrosa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera commented Jun 18, 2026

Uh oh!

Mingze129 commented Jun 18, 2026

Uh oh!

fgrosa commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Jun 18, 2026

Uh oh!

Uh oh!

vkucera Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

vkucera Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

vkucera Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

vkucera Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

vkucera Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

vkucera Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Jun 17, 2026 •

edited

Loading

fgrosa commented Jun 18, 2026 •

edited

Loading