Skip to content

[ALICE3] Add inner- and outermost hit information to alice 3 tracks - #18260

Merged
jesgum merged 3 commits into
AliceO2Group:masterfrom
jesgum:otf-tracks
Oct 13, 2026
Merged

jesgum merged 3 commits into
AliceO2Group:masterfrom
jesgum:otf-tracks

Conversation

@jesgum

@jesgum jesgum commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot changed the title Add inner- and outermost hit information to alice 3 tracks [ALICE3] Add inner- and outermost hit information to alice 3 tracks Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 119 warnings, 🔕 0 disabled

@jesgum
jesgum marked this pull request as ready for review October 12, 2026 14:23
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2e1e87e at 2026-10-13 06:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 6 errors and 58 warnings.'
Found 6 errors and 58 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/5725caea5deabb25b701183d35db574f12e36332/O2Physics-code-check/errors.txt
ALICE3/TableProducer/alice3TrackingTranslator.cxx:133:91: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:133:112: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:210:88: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:210:109: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:322:87: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:322:108: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
++ [[ 58 -gt 0 ]]
++ cat /sw/BUILD/5725caea5deabb25b701183d35db574f12e36332/O2Physics-code-check/warnings.txt
ALICE3/Core/DetLayer.h:64:3: warning: function 'getRadius' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:65:3: warning: function 'getZ' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:66:3: warning: function 'getRadiationLength' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:67:3: warning: function 'getDensity' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:68:3: warning: function 'getResolutionRPhi' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:69:3: warning: function 'getResolutionZ' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:70:3: warning: function 'getEfficiency' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:71:3: warning: function 'getType' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:72:3: warning: function 'getName' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:73:3: warning: function 'getDeadPhiRegions' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:76:3: warning: function 'isInert' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:77:3: warning: function 'isSilicon' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:78:3: warning: function 'isGas' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:79:3: warning: function 'isTOF' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:80:3: warning: function 'isVertex' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:81:3: warning: function 'isActive' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:84:3: warning: function 'toString' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:93:3: warning: function 'isInDeadPhiRegion' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/DetLayer.h:95:36: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Core/FastTracker.h:50:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
ALICE3/Core/FastTracker.h:140:3: warning: function 'getCovMatOK' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/FastTracker.h:141:3: warning: function 'getCovMatNotOK' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/FastTracker.h:154:15: warning: member 'mCrossSectionMinB' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/Core/GeometryContainer.cxx:43:8: warning: variable 'cleanLut' is not initialized [cppcoreguidelines-init-variables]
ALICE3/Core/GeometryContainer.cxx:70:5: warning: do not use 'else' after 'return' [readability-else-after-return]
ALICE3/Core/GeometryContainer.cxx:92:5: warning: do not use 'else' after 'return' [readability-else-after-return]
ALICE3/Core/GeometryContainer.h:48:3: warning: function 'getConfigurations' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:49:3: warning: function 'getConfiguration' should be marked [[nodiscard]] [modernize-use-nodiscard]
[0 more errors; see full log]

Full log here.

@jesgum
jesgum enabled auto-merge (squash) October 13, 2026 11:00

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jesgum.

@jesgum
jesgum merged commit 3c91d2c into AliceO2Group:master Oct 13, 2026
14 of 15 checks passed
@jesgum
jesgum deleted the otf-tracks branch October 13, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants