Repository navigation
[OGUI-1924] Fix incorrectly called disable auto scroll - #3675
Draft
isaachilly wants to merge 9 commits into
Draft
isaachilly wants to merge 9 commits into
isaachilly wants to merge 9 commits into
Conversation
Clearing logs or switching from a full query table to an empty live mode table shrinks the table. The scroll handler treated any decrease in `scrollTop` as the user scrolling up and disabled autoscroll. A decrease now only counts if the view is no longer at the bottom.
Adds tests covering scrolling up, switching from a full query table to an empty live mode table, clearing the logs and zooming in/out.
…bug/ILG/OGUI-1924/Fix-incorrectly-called-disableAutoScroll
isaachilly
added this pull request to stack #3676
October 9, 2026 15:34
isaachilly
changed the title
Add a wheel listener to the log table so upward scrolling immediately disables live auto-scroll. This was an issue in a CI/CD test where the scroll handler only checks scrollTop after the browser has actually scrolled. If a new log has made the browser jump back to the bottom before the check runs then the scroll is missed and autoScrollLive is kept enabled.
Last commit changed one too many instances of the old waitForScrollPastBottom calls
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created