Repository navigation
Fix ALTS terraform build with newer/older distro Go - #42
Merged
Merged
Conversation
- Bump terraform build version to v1.12.1: v1.11.4 sets godebug tlskyber, which Go 1.24+ rejects - Bump docker provider build version to 4.6.0 - Build with GOTOOLCHAIN=auto so nodes whose distro Go is older than go.mod requires fetch the needed toolchain (RHEL's go.env sets GOTOOLCHAIN=local) - Fix docker provider git version quoting (rendered as v"x.y.z")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
alts_terraformrole's "Build terraform" step, which failed on ALTS nodes in two different ways depending on the distro Go version:go.mod:9: unknown godebug "tlskyber". Terraform v1.11.4 setsgodebug tlskyber=0, a setting Go 1.24 removed.go.mod:329: unknown block type: tool. Terraform v1.12.1 uses thetooldirective (Go 1.24+). RHEL'sgo.envsetsGOTOOLCHAIN=local, so Go won't fetch the toolchaingo.modrequires.Changes
terraform_build_vertov1.12.1, matchingterraform_versionin the role defaultsdocker_build_verto4.6.0, the latest provider release (requires Go 1.25.8)GOTOOLCHAIN=autoso nodes download the toolchaingo.modrequires, whatever the distro Go version (needs Go >= 1.21 on the node plus internet access)versionquoting:v"{{ docker_build_ver }}"rendered asv"x.y.z"Notes
~> 3.xwill need updating.🤖 Generated with Claude Code