Repository navigation
Add GPL notices to vendored pulpcore modules - #45
Merged
Merged
Conversation
roles/pulp/files/export.py and datarepair.py are modified copies of pulpcore 3.114.1 modules, which are licensed under GPL-2.0-or-later, but the repository only carried the MIT license. GPLv2 requires modified copies to stay under the GPL, to state the changes and their date, and to come with the license text. - Add SPDX headers naming the upstream module and version, and the list of our modifications, to both files. - Add pulpcore's GPLv2 text as roles/pulp/files/COPYING.pulpcore. - Note the exception in the README license section and document what to keep in roles/pulp/files/README.md. - Fix the description of export.py: exporting streamed file:// content is already in upstream 3.114.1; our changes are the package timestamps and exporting into an existing directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roles/pulp/files/export.pyandroles/pulp/files/datarepair.pyare modified copies of whole pulpcore 3.114.1 modules. pulpcore is licensed under GPL-2.0-or-later, while this repository only carries the MIT license, so the files appeared to be MIT. For modified copies we distribute, GPLv2 requires that they:The upstream files have no per-file copyright headers, so nothing was stripped. The Ansible roles only copy these files into a locally built image, so the rest of the repository can stay MIT.
Changes
roles/pulp/files/export.py,roles/pulp/files/datarepair.py:SPDX-License-Identifier: GPL-2.0-or-laterheader, the upstream module and pulpcore version they're based on, and the list of our modifications with the year.roles/pulp/files/COPYING.pulpcore: GPLv2 text, verbatim from pulpcore 3.114.1LICENSE.README.md: new License section noting the exception for the two files.roles/pulp/files/README.md: License section listing what to keep when updating or adding vendored modules.roles/pulp/files/README.md,roles/pulp/defaults/main.yml: fixed theexport.pydescription. Exporting streamedfile://content is already upstream in 3.114.1 (pulp/pulpcore@d8279a709); our changes are package file timestamps and exporting into an existing directory.Testing
3.114.1to confirm the base version and the listed modifications.python3 -m py_compile); only comments were added to them.Follow-up
Upstreaming the timestamp fix (it imports
pulp_rpm, so probably as a pulp_rpm export hook) and thedatarepairmemory fix would let us drop the vendored copies.