-
Notifications
You must be signed in to change notification settings - Fork 134
feat(workspace): publish a locally-authored skill to the linked workspace #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
79f77e1
feat(workspace): publish a locally-authored skill to the linked works…
sahrizvi 77256d0
fix(workspace): three review findings on skill publish
sahrizvi 2be242d
fix(workspace): scope the published-skill ledger by account and seria…
sahrizvi d3cc5f7
fix(workspace): attach a published skill to the linked workspace
sahrizvi 084c030
fix(workspace): the attach envelope, bounded reads, and ledger identity
sahrizvi d412091
fix(workspace): a recorded id the server says is not ours falls throu…
sahrizvi e807448
fix(workspace): publish the whole bundle as a replacement, and tell t…
sahrizvi b1a0af2
fix(workspace): junk-file names are case-folded, and a worktree's .gi…
sahrizvi 232881c
fix(workspace): the server's file ceiling, no orphan on a workspace w…
sahrizvi 2920181
fix(workspace): find a legacy ledger row by directory, not by a diges…
sahrizvi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
H7 does not hold for malformed non-number IDs because
Numbercoerces values before validation. For example,GET /users/mereturning{"id":true}is accepted as user 1; if the workspace list omits its owner, publishing proceeds and writes the ledger underu1rather than throwingWorkspaceApiErroras claimed.Useful? React with 👍 / 👎.