Antalya 26.5: Fix condition for using parquet metadata cache#1960
Open
zvonand wants to merge 2 commits into
Open
Antalya 26.5: Fix condition for using parquet metadata cache#1960zvonand wants to merge 2 commits into
zvonand wants to merge 2 commits into
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #1751 from Altinity/feature/antalya-26.3/pr-1631 Antalya 26.3: Fix condition for using parquet metadata cache # Conflicts: # src/Storages/ObjectStorage/StorageObjectStorageSource.cpp # tests/integration/test_storage_iceberg_with_spark/test_read_constant_columns_optimization.py
Kept "ours" (antalya-26.5) side of the conflict in `StorageObjectStorageSource.cpp`. The actual fix from #1751 — wrapping the format comparison with `Poco::toLower` and using lowercase `"parquet"` — was already present on antalya-26.5. The "theirs" side additionally included `&& use_native_reader_v3`, which is not part of #1751's diff (it was pre-existing context on antalya-26.3) and does not exist on antalya-26.5, so it was not introduced. `configuration->format` (field access on antalya-26.5) is kept instead of `configuration->getFormat()` (method used on antalya-26.3).
zvonand
added
releasy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix apache iceberg queries not hitting the parquet metadata cache (#1631 by @arthurpassos) (#1751 by @zvonand).
CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #1751.
Documentation entry for user-facing changes
...