Skip to content

Fix numbered Paper build version parsing#181

Draft
SuperSaussage wants to merge 1 commit into
Andavin:masterfrom
SuperSaussage:supersaussage/fix-paper-build-version
Draft

Fix numbered Paper build version parsing#181
SuperSaussage wants to merge 1 commit into
Andavin:masterfrom
SuperSaussage:supersaussage/fix-paper-build-version

Conversation

@SuperSaussage

Copy link
Copy Markdown

Summary

  • Normalize the complete Bukkit version string before minor-version matching.
  • Strip both Paper's .build suffix and numbered .build.<number> suffixes.
  • Add regression coverage for Purpur's 26.1.2.build.2592-stable format and standard Bukkit formats.
  • Use ProtocolLib's current net.dmulloy2 Maven coordinates so the affected module can resolve and test cleanly.

Problem

Purpur can report a Bukkit version such as 26.1.2.build.2592-stable. The existing parser removes -stable, but only strips .build when it is the final suffix. It therefore treats 2592 as a Minecraft patch number and recursively decrements it, logging thousands of Unknown minor version warnings before eventually reaching 26.1.2.

This change normalizes that input directly to 26.1.2, which already maps to R1.

Testing

  • mvn -pl Images-Common test — 4 tests passed.
  • Updated the official 2.5.10 jar with the affected compiled classes and ran a direct jar-level parser harness against all four cases successfully.
  • mvn clean package builds and tests Images-Common, then stops at the unchanged legacy Images-v1_8_R3 module because org.spigotmc:spigot:1.8.8-R0.1-SNAPSHOT is no longer available from the configured public repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant