Fix numbered Paper build version parsing#181
Draft
SuperSaussage wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.buildsuffix and numbered.build.<number>suffixes.26.1.2.build.2592-stableformat and standard Bukkit formats.net.dmulloy2Maven coordinates so the affected module can resolve and test cleanly.Problem
Purpur can report a Bukkit version such as
26.1.2.build.2592-stable. The existing parser removes-stable, but only strips.buildwhen it is the final suffix. It therefore treats2592as a Minecraft patch number and recursively decrements it, logging thousands ofUnknown minor versionwarnings before eventually reaching26.1.2.This change normalizes that input directly to
26.1.2, which already maps toR1.Testing
mvn -pl Images-Common test— 4 tests passed.mvn clean packagebuilds and testsImages-Common, then stops at the unchanged legacyImages-v1_8_R3module becauseorg.spigotmc:spigot:1.8.8-R0.1-SNAPSHOTis no longer available from the configured public repositories.