Repository navigation
Run each notebook in its own process - #1663
Merged
Merged
Conversation
jph00
reviewed
Nov 5, 2026
| @@ -0,0 +1,9 @@ | |||
| from fastcore.nbio import new_nb, write_nb, mk_cell | |||
Contributor
There was a problem hiding this comment.
Careful not to add tests like this. It's a whole new test file just to test a fact that python already makes true by definition. AI is more than happy to let complexity in test suites blow up. It thinks of that as a good thing, because RLHF feedback rewards adding more tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
nbdev-testandnbdev-docsrun each notebook in a fresh process.They map notebooks over a
ProcessPoolExecutor, which reuses workers, and a worker keepssys.modulesbetween notebooks. So any module-level state one notebook changes is still there for the next notebook that lands in the same worker. Which notebooks share a worker depends on scheduling, so tests can pass or fail by chance, andnbdev-test --savecan write outputs that include another notebook's state.Both call sites now pass
max_tasks_per_child=1to fastcore'sparallel(fastcore#961) which retires a worker after one notebook.Requires
fastcore>=2.2.39and Python 3.11, so thetomlifallback is gone too.