Repository navigation
Support stripping specified output representations - #1664
Merged
Merged
Conversation
Contributor
|
This is a really smart approach :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
nbdev-cleanremoving output representations that a display object marks for stripping.An output whose metadata carries
{"nbdev": {"strip": ["text/html"]}}loses those mimetypes on clean and keeps the rest. A display object sets the flag by returning(data, metadata)from_repr_mimebundle_, which IPython forwards into the output's metadata. The stripping happens before output metadata is filtered, so noallowed_out_metadata_keysentry is needed.This is for rich outputs that are large, change on every run creating messy diffs, and have a small fallback beside them: e.g. an HTML bundle next to a Markdown or PNG representation. Today a project either commits the bundle or clears every output with
clear_all. With the flag, the notebook on disk and github can keep the small representation and the large one is regenerated by running the notebook.