Darkpack Pull 7/30/26 - #108
Merged
FalloutFalcon merged 47 commits intoJul 31, 2026
Merged
Conversation
## About The Pull Request from w20 core ## Why It's Good For The Game from w20 core and honestly kinda funny <img width="1172" height="783" alt="Screenshot 2026-07-26 122725" src="https://github.com/user-attachments/assets/b9b9aea5-c569-44e1-945a-877fc167e7bd" /> ## Changelog :cl: add: Added Monochrome Vision flaw for Garou /:cl:
## About The Pull Request Breaks the guestbook code up slightly and rewrites the code so that the primarly used define returns the MOB instead of the name. This means that in all scenarios where we directly imbued into a string (all of current uses), text macros work as intented https://ref.dm-lang.org/DM/text/macros/ I didnt check if this fixes anything persay but it likely affects situations for everything that is not a human (as they use macros alot more often) Also fixes <img width="1179" height="79" alt="image" src="https://github.com/user-attachments/assets/23501f8b-7c9d-4b86-8028-fa65ff9732fa" /> I discovered caused by a recent pr while leaving my game open (the dog i was testing barked) I orginnaly assumed this was what caused DarkPack13#1130 but that was acctually its own issue but i fixed it. ## Why It's Good For The Game Grammer good. Bugs bad. Fixes DarkPack13#1130 ## Changelog :cl: fix: Guestbook should handle text macros better fix: Dogs are treated as an improper noun /:cl:
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Moves hunger multipliers from DarkPack13#857 to a config rather then being in two seperate places which made it so our code has a * 0.04 of normal tg which is why no one got hungry. Default config value is set to 0.5 of normal TG values. This is something that should likely be tweaked. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game hunger rate is pretty subjective and depends on the length of the round and population imo. Having a ton of stores/food/cooking but NO reason to ever eat is bad. I might follow this up with a minor buff for eating player made food. <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and its effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: fix: Hunger is no longer accidentally soft-removed config: Hunger rate is on a config for easier tweaking /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
## About The Pull Request Adds the Cast-Iron Stomach from Bygone Bestiary. ## Why It's Good For The Game It's not a hugely important trait so honestly it isn't but I do like to eat raw meat as a Lupus so. https://github.com/user-attachments/assets/3abe68ce-58df-47d9-bbc4-5ce0cf6ceaab ## Changelog :cl: add: Added Cast-Iron Stomach as a merit /:cl:
## About The Pull Request Fixes Condottieri job's supervisor, changing it from SHERIFF to SOCIETY OF LEOPOLD ## Why It's Good For The Game Bugfix ## Changelog :cl: fix: Fixed Condottieri's supervisor property. /:cl:
## About The Pull Request Reworks the spawns for artifacts to defavor klaives extreamly hard, but put better spawns (that are guarded) into the umbra. Spawners work off a pool of points and match the power of artifacts spawned with banes guarding them. <img width="670" height="501" alt="image" src="https://github.com/user-attachments/assets/9540d448-44e6-40c8-9f2c-5a71a7418a3d" /> Also adds a new merit that lets you spawn with a **RANK 1** fetish round start. I could prob also extend this to a separate one for ghouls/vampires if thats desired. <img width="504" height="246" alt="image" src="https://github.com/user-attachments/assets/a5ef86d3-c577-4831-b431-65c2a01f9e4e" /> Adds a new homebrew fetish that listens VERY good and repeats random messages back when used. https://github.com/user-attachments/assets/cb2b076b-cba0-4e68-8e33-d46ccbc04324 ## Why It's Good For The Game Current spawns and systems dont have any particuarly leaning towards werewolves which feels strange as it ends up with alot of vampires/humans getting there hands on artifacts that werewolves will murder the fuck out of you for having. While they are still obtained-able through the means the strong ones should be alot rarer. And now the werewolves have a good reason to visit the umbra or spend points into merits. ## Changelog :cl: add: The umbra now spawns corpses with fetishes and banes surronding them add: Adds new minor werewolf fetish: Magpie's Ears add: Adds merit to have a roundstart fetish owned by you. balance: Klaives are MUCH rarer from normal spawns /:cl:
## About The Pull Request ran into this harddel downstream. this should hopefully fix it? ``` [2026-07-27 00:50:20.585] REFSCANNER: native refscan complete for /datum/discipline_power/bloodheal/one ([0x210ed59c]), took 2539 ms - === 1 finding(s)=== - [finding] datum #971514 (/datum/discipline/bloodheal).current_power ``` ## Why It's Good For The Game harddel bad ## Changelog :cl: fix: Fixed a laggy hard delete related to disciplines. /:cl:
## About The Pull Request Runtime from not having an auspice, Prob corax. <img width="1238" height="262" alt="image" src="https://github.com/user-attachments/assets/49fdee93-13b9-4dae-a94f-c03b59acf265" /> Runtime from trying to check the beating of a heart for a a heart that doesnt exist. Kinfolk dont have a tribe so runtime trying to compare tribes. <img width="1127" height="410" alt="image" src="https://github.com/user-attachments/assets/5e61da48-55aa-4cbc-a892-54b4b4863857" /> Bad arg order on planter. <img width="1348" height="252" alt="image" src="https://github.com/user-attachments/assets/87203bbd-8f9d-46f0-aba7-5d561aa141fa" /> ## Why It's Good For The Game Runtimes bad. ## Changelog :cl: fix: Improves handling for detecting a heartbeat to be more consistent code: Fixes random runtimes /:cl:
## About The Pull Request it currently displays %TIME% ## Why It's Good For The Game fixing a display issue ## Changelog :cl: fix: fixed a few things /:cl:
## About The Pull Request the camarilla on crimson grid were executing breachers (since no one knew what the masquerade was and was just popping crinos and celerity in the streets breaching on every npc and didn't consider WHY the npcs had big red excalamation points over their heads...) only to find out that if they execute a breacher the masquerade isn't restored - meaning their entire gameplay loop of hunting down breachers is useless at worst and 'can you pwetty please execute the npc even though you dont know where it is' at best fixes DarkPack13#1248 ## Why It's Good For The Game punish breachers and repair the masq ## Changelog :cl: add: adds functionality for clearing masquerade breaches upon the death of any mob/living, admins can also use the 'AdjustMasquerade' proc to restore people's breaches now as it wasnt working before /:cl:
## About The Pull Request Expands our soundscape. This is not the final version I want as I think I want to do a greater pr rerwriting the underlying ambience code to be able to have finer control over paramaters for individual sets of sounds. The current code struggles to decently control rarity as sounds just have to be pooled in a massive list (meaning i have to specificly cull sounds to keep there rarity under control). The new system will likely datumize each set of sounds. ## Why It's Good For The Game The current soundscape has alot of issues, including that some areas just have the TG generic ambinece. Alot of our ambient sounds are loops that aren't actually playing on loops but also sound ass because they loop poorly. No longer will every interior you walk into have the same weird shop sounds ## Changelog :cl: add: Adds a large set of new ambiences to mostly replace the old ones. add: Pipes and stalagmites have a chance to have dripping sounds playing add: Light tubes have a chance to have an ambient buzz add: Adds a `looping_sound_emitter` object for mapping that can be vareditted to have a looping sound easier. fix: Fills in the gaps of the ambience buzzs and sounds so that Space ambience no longer plays /:cl:
## About The Pull Request Make it a normal ass screen size instead of 3. ## Why It's Good For The Game Its in an annoying spot where its just small enough that you regularly have to step forward awkwardly to guestbook a new friend ## Changelog :cl: balance: You can guestbook from a full screen width /:cl:
## About The Pull Request the lines below only add to recoil_roll's difficulty but never resets or subtracts - making it always trend toward 10 and above. ## Why It's Good For The Game bug ## Changelog :cl: fix: fixes firearms recoil roll difficulty never being reset /:cl:
## About The Pull Request allows admins to set generations below MAX_TRUSTED_GENERATION to LOWEST_GENERATION_LIMIT ## Why It's Good For The Game spooky elders in your area ## Changelog :cl: add: Admins can now set generations below 8 /:cl:
## About The Pull Request Jobs are generation-limited. Elders only in leadership, Ancillae only in 'faction' jobs (used loosely here; basically everything except Citizen/Janitor.) Exception made for Taxi Driver because I swear I have a sense of humor and/or a soul. ## Why It's Good For The Game Desired for downstream, made it a config. Infinite civilians stronger than the Hounds expected to keep them in check is bad for gameplay. ## Changelog :cl: config: Added a config setting to limit high generations to a limited selection of jobs /:cl:
## About The Pull Request 2 verbs. one for all actions (filtering for types that already get vv topics) and one just for powers. This doesnt change the fact that the current gift code only lets werewolf splats have it. You can make someone a kinfolk to get around that tho. ## Why It's Good For The Game Adminbus Good ## Changelog :cl: admin: 2 VV topics for managing actions or gifts /:cl:
## About The Pull Request Delirium was not being applied. Fixes DarkPack13#1298 ## Changelog :cl: fix: Delirium will properly be applied /:cl:
## About The Pull Request RED news reporter original pr by bomby ## Why It's Good For The Game use in conjunction with mapped entertainment modules or evac status displays and greenscreens and captain caster objects for live feeds to all the citizens ## Changelog :cl: add: Adds the red news reporter role which can broadcast to the city using the captain-caster camera and mapped-in greenscreens as well as 'entertainment monitors' and the mobile cameras /:cl:
## About The Pull Request see title ## Why It's Good For The Game if hunters are to hunt they should know who to hunt. also means there's a particularly big downside to breaching outside of the camarilla; the entire reason the camarilla cracks down on breaches (the inquisition sucked for them!) ## Changelog :cl: add: Gave the Society of Leopold intel reports to find breachers with add: Added more breach phrases to the list /:cl:
## About The Pull Request Original PR by Nimi The-Final-Nights/The-Final-Nights-Rebase#330 reworked by me to fit upstream this is becoming necessary after the crimson-grid playtest many people had no clue WTF anything was and filling them in on lore is paramount. ## Why It's Good For The Game new players ## Changelog :cl: add: expands lore primers to help new players figure out what morality paths are as well as some stuff about Garou, Clans, etc /:cl: --------- Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
## About The Pull Request nukes the `sort_list` calls from `/obj/item/smartphone/ui_data`, moving them to client-side sorts in the actual tgui. testing proof: <img width="908" height="552" alt="2026-07-28 (1785274243) ~ dreamseeker" src="https://github.com/user-attachments/assets/cec9c064-7d49-465b-8867-357dcbe8d645" /> ## Why It's Good For The Game less server-side lag ## Changelog :cl: fix: made smartphone contacts lag the server less /:cl:
…o apoc-pull-7-30-26
FalloutFalcon
added
the
Upstream Merge
FalloutFalcon
enabled auto-merge
July 31, 2026 03:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.