fix(events): separate opaque ids from cursor ordinals - #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new_event_id()has an alphabetic hex namespace marker, preventing opaque IDs from overlapping decimal cursor ordinalsRoot cause
event_ordinal()accepts decimal event IDs as a compatibility fallback. The previousnew_event_id()returneduuid4().hex[:16]; because the UUID4 version nibble is always4, the complete ID was decimal with probability(10/16)^15, about 1 in 1,153. On those events,AgentComm.consume()accepted the opaque ID as an ordinal and advanced its in-process cursor to a huge non-monotonic value.Compatibility
The generated ID remains exactly 16 lowercase hexadecimal characters. The explicit
emarker replaces the non-random UUID version nibble, so collision entropy remains 60 bits. Decimal IDs assigned by legacy stores remain accepted byevent_ordinal().Validation
uv run pytest -q: 1510 passed, 1 skippeduv run ruff check .: passeduv run pyright: 0 errorsuv build: wheel and sdist built successfullygit diff --check: passed