You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Benchmark runs now load the full filtered question set before applying the seeded shuffle and --limit. Different seeds can therefore select different question subsets, while --no-shuffle continues to select the canonical prefix.
full .venv/bin/pytest -q — 1707 passed, 4 skipped, 2 failed outside this change
the network failure also reproduces on untouched origin/main because this environment resolves www.iana.org to reserved address 198.18.1.21
the TUI timing failure passed on isolated rerun
The repository-wide Ruff baseline currently reports existing formatting and lint findings; the modified Python files pass ruff check, and the new test file passes the formatter check.
AI assistance was used during implementation. I reviewed the final diff and ran the verification listed above.
The regression coverage makes sense, but could we combine these into one parameterized test for the two seeds and --no-shuffle, sharing the setup? A loader stub that honors limit would let the selected-ID assertions catch the original bug directly, without also asserting that limit was omitted from the call.
Thanks, that makes sense. Updated in 2cff817: the two seeds and --no-shuffle now share one parameterized test, and the loader stub honors limit. The assertions check the selected IDs directly; the assertion about the loader call is gone.
All three cases pass, and Ruff passes. I also checked the regression by restoring the original limit-before-shuffle behavior in the test process: both seeded cases fail on the selected IDs, while --no-shuffle still passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmark runs now load the full filtered question set before applying the seeded shuffle and
--limit. Different seeds can therefore select different question subsets, while--no-shufflecontinues to select the canonical prefix.Fixes #32
Changes
load_questions()before shufflingVerification
.venv/bin/pytest tests/test_benchmark_runner_sampling.py -q— 2 passed.venv/bin/ruff check benchmarks/public/runner/run_subprocess.py tests/test_benchmark_runner_sampling.py— passed.venv/bin/python tools/import_smoke.py— 338/338 modules imported.venv/bin/pytest -q— 1707 passed, 4 skipped, 2 failed outside this changeorigin/mainbecause this environment resolveswww.iana.orgto reserved address198.18.1.21The repository-wide Ruff baseline currently reports existing formatting and lint findings; the modified Python files pass
ruff check, and the new test file passes the formatter check.AI assistance was used during implementation. I reviewed the final diff and ran the verification listed above.