Corrected touch target boundaries for various chart types#791
Open
venkatbhoogarbh wants to merge 2 commits into
Open
Corrected touch target boundaries for various chart types#791venkatbhoogarbh wants to merge 2 commits into
venkatbhoogarbh wants to merge 2 commits into
Conversation
…Bar charts, Pie charts, Stack charts, and many more
Collaborator
|
Hm, I'm not sure if we bump minSdk to 24 only because of this. Please give me an argument to do so. |
Collaborator
|
according to https://apilevels.com/ |
Author
|
I changed it appropriately to use a standard for-in loop, preserving full API 23 compatibility. Thank you for pointing that out! |
Collaborator
|
Thanks a lot for your afford. As forks can't makes screenshot compare test, I made a copy of this PR #794 to enable this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix: Corrected touch target boundaries and stack selection logic for Bar charts, Pie charts, Stack charts, and many more