fix: add setter for rendererXAxis to match rendererLeftYAxis/rendererRightYAxis API#797
Merged
hannesa2 merged 1 commit intoJun 19, 2026
Conversation
…RightYAxis API Converts rendererXAxis from a val (getter-only) to a var with a setter that writes to the protected xAxisRenderer backing field, mirroring the identical pattern used by rendererLeftYAxis and rendererRightYAxis. Fixes AppDevNext#782
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rendererXAxisfrom a read-onlyval(getter only) to avarwith both getter and setter inBarLineChartBasexAxisRendererbacking field, following the identical pattern already used byrendererLeftYAxisandrendererRightYAxisWhy this matters
Issue #782 reports that callers cannot substitute a custom
XAxisRenderersubclass the same way they can for Y-axis renderers. The asymmetry is a gap in the API:rendererLeftYAxisandrendererRightYAxisare bothvarwith setters, whilerendererXAxiswasval. This is a common customization (e.g., custom label formatting or line drawing). The backing fieldxAxisRendereris already declaredprotected var, so this change requires no visibility changes - only the property accessor needed updating.Testing
rendererLeftYAxissetter pattern exactly (backing field assignment)xAxisRendereris aprotected varacceptingXAxisRendererassignmentFixes #782